[SSSD] [PATCHES] krb5: new option krb5_map_user

Jakub Hrozek jhrozek at redhat.com
Wed May 27 08:38:10 UTC 2015


On Wed, May 27, 2015 at 09:52:11AM +0200, Lukas Slebodnik wrote:
> >+static errno_t
> >+get_krb_primary(struct map_id_name_to_krb_primary *name_to_primary,
> >+                char *id_prov_name, bool cs, const char **_krb_primary)
> >+{
> >+    errno_t ret;
> >+    int i = 0;
> >+
> >+    while(name_to_primary != NULL &&
> >+          name_to_primary[i].id_name != NULL &&
>                                                ^^
>                                         I thought we have a convention to use
>                                         binary operatort in the begining of
>                                         line and not at the end.
> 
> IIRC Stephen sent mail with proposal and we agreed.
> Sumit uses it quite often.

Is that a nack or a remark?

btw these proposals should be really codified in the coding style on
freeipa wiki (or our own coding style forked from freeipa).



More information about the sssd-devel mailing list