[SSSD] [PATCH] SSSDConfigTest: Use unique temporary directory

Lukas Slebodnik lslebodn at redhat.com
Tue May 26 16:19:05 UTC 2015


On (26/05/15 15:12), Jakub Hrozek wrote:
>On Tue, May 26, 2015 at 11:17:46AM +0200, Jakub Hrozek wrote:
>> On Mon, May 25, 2015 at 03:28:30PM +0200, Lukas Slebodnik wrote:
>> > On (22/05/15 16:13), Jakub Hrozek wrote:
>> > >On Thu, May 21, 2015 at 01:43:19PM +0200, Lukas Slebodnik wrote:
>> > >> ehlo,
>> > >> 
>> > >> There were some failed tests in ci log
>> > >> http://sssd-ci.duckdns.org/logs/job/12/67/fedora_rawhide/ci.html
>> > >> http://sssd-ci.duckdns.org/logs/job/14/07/fedora_rawhide/ci.html
>> > >> http://sssd-ci.duckdns.org/logs/job/14/97/debian_testing/ci.html
>> > >> 
>> > >> Attached patch should fix race condition between two SSSDConfigTest tests.
>> > >> The problem is just in master due to python{2,3} changes.
>> > >> 
>> > >> LS
>> > >
>> > >The intent is good, but I would prefer using the setUp() and tearDown()
>> > >methods for creating and removing the directory.
>> > I wanted to left temp dir for analysis,
>> > but code is stable and in case of problem it's easy
>> > to debug with "python -m pdb"
>> > 
>> > >It's safe because the Python documentation says:
>> > >    If setUp() succeeded, the tearDown() method will be run whether
>> > >    runTest() succeeded or not.
>> > Updated version of attached.
>> > 
>> > LS
>> 
>> I didn't reproduce the failure, but the code now looks good to me and
>> the tests pass.
>> 
>> ACK
>
>* master: 62b20154899f847e760d6dfbae6a32fb45b448de
thank you
and now the latest problematic test is dyndns

LS



More information about the sssd-devel mailing list