[SSSD] [PATCH] LDAP: Remove dead assignment

Lukas Slebodnik lslebodn at redhat.com
Mon May 18 14:39:04 UTC 2015


ehlo,

The variable ret was not read when function sysdb_has_enumerated
returned ENOENT. Just boolean variable has_enumerated need to be changed.
This dead assignment caused warning from clang static analyser
  Value stored to 'ret' is never read

LS
-------------- next part --------------
>From 94fac2f6f158de4611972c000e5fb87cdf87c78d Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 6 Mar 2015 20:18:19 +0100
Subject: [PATCH] LDAP: Remove dead assignment

The variable ret was not read when function sysdb_has_enumerated
returned ENOENT. Just boolean variable has_enumerated need to be changed.
This dead assignment caused warning from clang static analyser
  Value stored to 'ret' is never read
---
 src/providers/ldap/ldap_id_enum.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/providers/ldap/ldap_id_enum.c b/src/providers/ldap/ldap_id_enum.c
index 89c305c0d73fdbe07fc222773c9fff34c4dbc3a1..bc1b020c4dc1e5139ab03af187ea5a61666128c7 100644
--- a/src/providers/ldap/ldap_id_enum.c
+++ b/src/providers/ldap/ldap_id_enum.c
@@ -47,7 +47,6 @@ errno_t ldap_setup_enumeration(struct be_ctx *be_ctx,
     if (ret == ENOENT) {
         /* default value */
         has_enumerated = false;
-        ret = EOK;
     } else if (ret != EOK) {
         return ret;
     }
-- 
2.4.0



More information about the sssd-devel mailing list