[SSSD] [PRELIMINARY][PATCH] ifp users and groups

Pavel Březina pbrezina at redhat.com
Wed May 13 14:51:53 UTC 2015


On 05/11/2015 05:58 PM, Jakub Hrozek wrote:
> Thanks for the patches. They work quite well!
>
> One bug I found is that if you query a nonexistant object path with
> GetAll, then all subsequent queries block. Maybe we don't finish some
> request on error? This is what I tried:
> [jhrozek at client] sssd $ [(review)] dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users/redhat_2ecom/10327 org.freedesktop.DBus.Properties.GetAll string:org.freedesktop.sssd.infopipe.Users.User
> Error org.freedesktop.DBus.Error.NoReply: Message did not receive a reply (timeout by message bus)
> [jhrozek at client] sssd $ [(review)] dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users/linux_2etest/465400000 org.freedesktop.DBus.Properties.GetAll string:org.freedesktop.sssd.infopipe.Users.User
> Error org.freedesktop.DBus.Error.TimedOut: Activation of org.freedesktop.sssd.infopipe timed out
>
> The first objectpath is a copy-n-paste error from a different machine,
> the second is legitimate. All works well unless I use the nonexistant path.

Container wasn't closed properly and it broke the bus.

diff --git a/src/sbus/sssd_dbus_invokers.c b/src/sbus/sssd_dbus_invokers.c
index b2f0de0..f4d4ba3 100644
--- a/src/sbus/sssd_dbus_invokers.c
+++ b/src/sbus/sssd_dbus_invokers.c
@@ -336,6 +336,12 @@ int sbus_invoke_get_aDOsasDE(DBusMessageIter *iter,
      /* iterate over keys */

      if (table == NULL) {
+        dbret = dbus_message_iter_close_container(iter, &it_array);
+        if (!dbret) {
+            ret = EIO;
+            goto done;
+        }
+
          ret = EOK;
          goto done;
      }


New patches are attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sbus-provide-custom-error-names.patch
Type: text/x-patch
Size: 2222 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sbus-add-sbus_opath_decompose-_exact.patch
Type: text/x-patch
Size: 10476 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-sbus-add-a-sas-get-invoker.patch
Type: text/x-patch
Size: 23860 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-IFP-add-org.freedesktop.sssd.infopipe.Users.patch
Type: text/x-patch
Size: 24014 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-IFP-add-org.freedesktop.sssd.infopipe.Users.User.patch
Type: text/x-patch
Size: 40485 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-IFP-add-org.freedesktop.sssd.infopipe.Groups.patch
Type: text/x-patch
Size: 19084 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-IFP-add-org.freedesktop.sssd.infopipe.Groups.Group.patch
Type: text/x-patch
Size: 25891 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-IFP-deprecate-GetUserAttr.patch
Type: text/x-patch
Size: 1010 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150513/ab068036/attachment-0007.bin>


More information about the sssd-devel mailing list