[SSSD] [PATCHES] IPA: fixed for initgroups with overrides

Jakub Hrozek jhrozek at redhat.com
Wed May 6 04:00:07 UTC 2015


On Tue, May 05, 2015 at 03:22:14PM +0200, Jakub Hrozek wrote:
> On Thu, Apr 30, 2015 at 04:50:44PM +0200, Jakub Hrozek wrote:
> > On Wed, Apr 29, 2015 at 05:34:29PM +0200, Sumit Bose wrote:
> > > +static errno_t ipa_get_ad_ipa_membership_step(struct tevent_req *req)
> > > +{
> > > +    struct ipa_get_ad_acct_state *state = tevent_req_data(req,
> > > +                                                struct ipa_get_ad_acct_state);
> > > +    errno_t ret;
> > 
> > Sorry, there's one more warning, the 'ret' here is unused.
> > 
> > > +    struct tevent_req *subreq;
> > >  
> > >      /* For initgroups request we have to check IPA group memberships of AD
> > >       * users. This has to be done for other user-request as well to make sure
> > > -- 
> > > 2.1.0
> > > 
> > 
> > > _______________________________________________
> > > sssd-devel mailing list
> > > sssd-devel at lists.fedorahosted.org
> > > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> 
> I only found an unrelated issue with the default trust view and group
> members in my testing. Our Red Hat QE colleagues also confirmed that the
> patches don't break anything, so I'll ACK them and fix the unused ret
> before pushing.

Coverity and CI runs came clean. Pushed to master:
    * 2263c6dd1242c92253240f4998c86a04b6a0ca3a
    * 145578006684481434ced78461ab8d1c3570f478
    * cffe3135f29c737f2598f3c1384bfba1694fb843
    * e87badc0f6fb20a443cf12bde9582ecbc2aef727
and sssd-1-12:
    * eaf656843831d579f30f94154d88aba2201c1712
    * 58a19d50888b1a7da0ee78b49e7d3dcbebc8614d
    * f643fadbd072a9d3725f5f750340d5b13628ce6a
    * 24905d4ecbf210687e385449448f5a5ec97d2833



More information about the sssd-devel mailing list