[SSSD] [PRELIMINARY][PATCH] ifp users and groups

Lukas Slebodnik lslebodn at redhat.com
Tue May 5 13:50:24 UTC 2015


On (05/05/15 15:32), Pavel Březina wrote:
>On 05/05/2015 03:05 PM, Lukas Slebodnik wrote:
>>On (04/05/15 14:51), Pavel Březina wrote:
>>>New patches are attached. All review-issues should be addressed. Those
>>>patches contains also extraAttributes, group members and user attributes acl.
>>>
>>>Do we want to implement group attributes acl also?
>>>
>>>The groups and users attributes on group object do not reply with full
>>>recursive membership at the moment since we do not store in on groups object
>>>in sysdb... is it possible to leave it this way or should I compute the
>>>membership? Sysdb only contains full user members (in memberuid attribute),
>>>but it contains only direct group members (in member attribute).
>>>
>>
>>Subject:    IFP: remove GetUserAttr and GetUserGroup
>>Hash:       4d680cb2e44b453cd2822d3d0d937c336b1bad9c
>>Branch:     master
>>Job:        1404
>>Tests:      rigorous
>>Hosts:      rhel7           failed  http://sssd-ci.duckdns.org/logs/job/14/04/rhel7/ci.html
>>             rhel6           failed  http://sssd-ci.duckdns.org/logs/job/14/04/rhel6/ci.html
>>             debian_testing  failed  http://sssd-ci.duckdns.org/logs/job/14/04/debian_testing/ci.html
>>             fedora20        failed  http://sssd-ci.duckdns.org/logs/job/14/04/fedora20/ci.html
>>             fedora_rawhide  failed  http://sssd-ci.duckdns.org/logs/job/14/04/fedora_rawhide/ci.html
>>Overall:                    FAILED
>>
>>The summary above is available at:
>>http://sssd-ci.duckdns.org/logs/job/14/04/summary.html
>>http://sssd-ci.duckdns.org/logs/commit/4d/680cb2e44b453cd2822d3d0d937c336b1bad9c/1404/summary.html
>>
>>
>>It is not a coincidence that all tests failed.
>>@see http://sssd-ci.duckdns.org/logs/job/14/04/fedora_rawhide/ci-build-debug/test-suite.log
>>
>>LS
>
>Actually it is, all tests pass on my machine with these patches. Are you able
>to reproduce locally?
>
Yes,

I was also able to reproduce in clean environment (mock)
Try to create srpm
  contrib/fedora/make_srpm.sh
ant then rebuild in mock
  mock --root fedora-21-x86_64 --resultdir . --rebuild ./sssd-1.12.90-0.fc22.src.rpm

Or run CI script locally (@see contrib/ci/README.md in sssd git)



There is a warning, which can be related.

src/sbus/sssd_dbus_invokers.c: In function 'sbus_invoke_get_aDOsasDE':
src/sbus/sssd_dbus_invokers.c:413:12: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     return ret;
            ^
cc1: all warnings being treated as errors


There is a missing "ret = EOK" at the end of function.

LS



More information about the sssd-devel mailing list