[SSSD] [PATCH] test_ldap_auth: Use right assertion for integer comparison

Lukas Slebodnik lslebodn at redhat.com
Wed Mar 25 14:20:35 UTC 2015


ehlo,

simple patch is attached.

LS
-------------- next part --------------
>From b226c943557de7755cb542aa99f0e9efaa597f0d Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Wed, 25 Mar 2015 15:14:59 +0100
Subject: [PATCH 2/2] test_ldap_auth: Use right assertion for integer
 comparison

The macro assert_int_equal prints value of integers if
they are not equal.
---
 src/tests/cmocka/test_ldap_auth.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/tests/cmocka/test_ldap_auth.c b/src/tests/cmocka/test_ldap_auth.c
index 925fb0fa555f1af6e8d3539ba01b5c535aadb5aa..a2c3559f5e933ab38185aded87985885f04a163d 100644
--- a/src/tests/cmocka/test_ldap_auth.c
+++ b/src/tests/cmocka/test_ldap_auth.c
@@ -58,19 +58,19 @@ static void test_pwexpire_krb(void **state)
 
     ret = check_pwexpire_policy(type,
                                 (void*) tc->invalid_longer_format, NULL, 0);
-    assert_true(ret == ERR_TIMESPEC_NOT_SUPPORTED);
+    assert_int_equal(ret, ERR_TIMESPEC_NOT_SUPPORTED);
 
     ret = check_pwexpire_policy(type, (void*) tc->invalid_format,
                                 NULL, 0);
-    assert_true(ret == ERR_TIMESPEC_NOT_SUPPORTED);
+    assert_int_equal(ret, ERR_TIMESPEC_NOT_SUPPORTED);
 
     ret = check_pwexpire_policy(type, (void*) tc->past_time,
                                 NULL, 0);
-    assert_true(ret == ERR_PASSWORD_EXPIRED);
+    assert_int_equal(ret, ERR_PASSWORD_EXPIRED);
 
     ret = check_pwexpire_policy(type, (void*) tc->future_time,
                                 NULL, 0);
-    assert_true(ret == EOK);
+    assert_int_equal(ret, EOK);
 
     /* changing time zone has no effect as time of expiration is in UTC */
     struct check_pwexpire_policy_wrap_indata data;
@@ -80,14 +80,14 @@ static void test_pwexpire_krb(void **state)
                    check_pwexpire_policy_wrap,
                    (void*)&data,
                    (void*)&ret);
-    assert_true(ret == EOK);
+    assert_int_equal(ret, EOK);
 
     data.time_fmt = (void*)tc->past_time;
     expire_test_tz("GST-2",
                    check_pwexpire_policy_wrap,
                    (void*)&data,
                    (void*)&ret);
-    assert_true(ret == ERR_PASSWORD_EXPIRED);
+    assert_int_equal(ret, ERR_PASSWORD_EXPIRED);
 }
 
 int main(void)
-- 
2.3.3



More information about the sssd-devel mailing list