[SSSD] [PATCH] sdap: properly handle binary objectGuid attribute

Jakub Hrozek jhrozek at redhat.com
Fri Mar 20 12:32:05 UTC 2015


On Fri, Mar 20, 2015 at 12:26:15PM +0100, Jakub Hrozek wrote:
> On Fri, Mar 20, 2015 at 12:02:55PM +0100, Sumit Bose wrote:
> > On Fri, Mar 20, 2015 at 11:48:28AM +0100, Jakub Hrozek wrote:
> > > On Tue, Mar 17, 2015 at 04:46:22PM +0100, Sumit Bose wrote:
> > > > On Tue, Mar 10, 2015 at 12:31:59PM +0100, Sumit Bose wrote:
> > > 
> > > My only nitpick would be that we should either add a comment or define a
> > > const int in the function with a descriptive name to avoid "magical"
> > > constants.
> > 
> > new version with GUID_BIN_LENGTH attached.
> > 
> > bye,
> > Sumit
> 
> ACK

* master: 1d93029624d708119bbf803e6647a2cbb271f001

In order to give out test builds I backported the patch to 1-12:
    https://fedorapeople.org/cgit/jhrozek/public_git/sssd.git/commit/?h=review-1-12&id=c2bda7c5321e3a8f52656de43fe671c1f7f26e84

The only conflict was in src/tests/cmocka/test_utils.c



More information about the sssd-devel mailing list