[SSSD] [PATCH] IPA: make sure output variable is set

Sumit Bose sbose at redhat.com
Thu Mar 19 14:12:45 UTC 2015


On Thu, Mar 19, 2015 at 02:50:16PM +0100, Pavel Reichl wrote:
> 
> 
> On 03/19/2015 02:31 PM, Sumit Bose wrote:
> >Hi,
> >
> >Steeve found another issue while testing with older FreeIPA server
> >versions. This patch should fix it.
> >
> >bye,
> >Sumit
> >
> >
> >_______________________________________________
> >sssd-devel mailing list
> >sssd-devel at lists.fedorahosted.org
> >https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> 
> Thanks, LGTM. ci passed -
> 
> http://sssd-ci.duckdns.org/logs/job/11/14/summary.html
> 
> 
> I have just one question related to your patch - please see snippet from the
> same function:
> >   for (c = 0; members[c] != NULL; c++) {
> >        obj_domain = find_domain_by_object_name(parent_domain,
> >members[c]);
> >        if (obj_domain == NULL) {
> >            DEBUG(SSSDBG_OP_FAILURE, "find_domain_by_object_name
> >failed.\n");
> >            ret = ENOMEM;
> >            goto done;
> >        }
> >
> >        ret = sysdb_search_user_by_name(tmp_ctx, obj_domain, members[c],
> >NULL,
> >                                        &msg);
> >        if (ret == EOK) {
> >            if (group_attrs != NULL) {
> >                dn_str = ldb_dn_get_linearized(msg->dn);
> >                if (dn_str == NULL) {
> >                    DEBUG(SSSDBG_OP_FAILURE, "ldb_dn_get_linearized
> >failed.\n");
> Should we set 'ret' here to some errorcode or set '_missing_members' same
> way you did in your patch?

good catch, 'ret = EINVAL' should be added here. Would you like to fix
this or shall I squash it into this patch?

bye,
Sumit

> 
> Thanks!
> 
> >                    goto done;
> >                }
> >
> >                DEBUG(SSSDBG_TRACE_ALL, "Adding member [%s][%s]\n",
> >                                        members[c], dn_str);
> 
> 

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list