[SSSD] [PATCH] cache_req: fix ret may be uninitialized

Lukas Slebodnik lslebodn at redhat.com
Tue Mar 17 10:34:35 UTC 2015


On (17/03/15 11:27), Pavel Březina wrote:
>This warning somehow slipped in.

>From fc6afcfe73a2a2fe3f2be7ac4a49c5bf56a18a09 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina at redhat.com>
>Date: Tue, 17 Mar 2015 11:26:41 +0100
>Subject: [PATCH] cache_req: fix ret may be uninitialized
>
>---
> src/responder/common/responder_cache_req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/responder/common/responder_cache_req.c b/src/responder/common/responder_cache_req.c
>index 26ef06dbd1994949a99f2b5a0b8c8f8c5f14c600..8388f4bb482ba6c9b42d1e40791cf22653585f53 100644
>--- a/src/responder/common/responder_cache_req.c
>+++ b/src/responder/common/responder_cache_req.c
>@@ -274,7 +274,7 @@ static void cache_req_add_to_ncache(struct cache_req_input *input,
> static void cache_req_add_to_ncache_global(struct cache_req_input *input,
>                                            struct sss_nc_ctx *ncache)
> {
>-    errno_t ret;
>+    errno_t ret = ERR_INTERNAL;
> 
>     switch (input->type) {
>     case CACHE_REQ_USER_BY_NAME:

@see https://lists.fedorahosted.org/pipermail/sssd-devel/2015-March/022959.html

My commit message is little bit verbose.
The subject is confusing because I forgot to remove "ipa_selinux:" when I sent
patches.

LS



More information about the sssd-devel mailing list