[SSSD] [PATCH] ldap_child: fix coverity warning

Pavel Reichl preichl at redhat.com
Mon Mar 9 10:24:44 UTC 2015


Hello,

please see attached trivial patch fixing 2 coverity warnings - ret was 
overriden without being read first.

> done:
>     if (krberr != 0) KRB5_SYSLOG(krberr);
>     if (keytab) krb5_kt_close(context, keytab);
>     if (context) krb5_free_context(context);
>     if (ccname_file_dummy) {
>     DEBUG(SSSDBG_TRACE_INTERNAL, "Unlinking [%s]\n", ccname_file_dummy);
>         ret = unlink(ccname_file_dummy);
>         if (ret == -1) {
>             ret = errno;
>             DEBUG(SSSDBG_MINOR_FAILURE,
>                   "Unlink failed [%d][%s].\n", ret, strerror(ret));
>         }
>     }
>     talloc_free(tmp_ctx);
>     return krberr;
ci:

http://sssd-ci.duckdns.org/logs/job/9/03/summary.html


Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldap_child-fix-coverity-warning.patch
Type: text/x-patch
Size: 1382 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150309/f8ff199b/attachment.bin>


More information about the sssd-devel mailing list