[SSSD] [PATCH] MONITOR: Poll for resolv.conf if not available during boot

Pavel Reichl preichl at redhat.com
Mon Jun 29 09:39:30 UTC 2015



On 06/25/2015 04:31 PM, Michal Židek wrote:
> On 06/25/2015 01:30 PM, Pavel Reichl wrote:
>>
>>
>> On 06/24/2015 03:35 PM, Michal Židek wrote:
>>> [snip]
>> Michal would you consider renaming 'missing_resolv_conf' to
>> 'check_resolv_conf' or something like that and  then replace following
>> code segment by simple call of it? I think we could save a few lines of
>> code and reuse the function.  Do you see any problems about that? 
>> Thanks!
>
> You are right that it would save us few lines, but It would also require
> directly calling a function that was made as tevent callback. I tried it
> and it looks IMO uglier (just filling the arguments to the function
> looks weird). So I would not go that way if you do not insist on it.
>
OK, thank you for investigating that proposal.  Code looks good to me. 
CI passed: http://sssd-ci.duckdns.org/logs/job/18/26/summary.html

I tried to remove resolv.conf and restart SSSD, then I saw your debug 
messages in log file and could not resolve a user. After adding 
resolf.conf back debug message stopped to show in log and the user could 
be resolved.

Unless somebody else has some ideas about further testing or code 
comments I think we can ACK the patch.

Thanks for patience!




More information about the sssd-devel mailing list