[SSSD] [PATCH] SDAP: Remove user from cache for missing user in LDAP

Michal Židek mzidek at redhat.com
Fri Jun 19 16:32:56 UTC 2015


On 06/19/2015 06:03 PM, Jakub Hrozek wrote:
> On Fri, Jun 19, 2015 at 05:59:04PM +0200, Michal Židek wrote:
>> On 06/18/2015 06:13 PM, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> regression was cuased by patch d0b7e5fcfca7d0db9e3d19be7b51f34d03d3d720
>>> because function sysdb_get_real_name overrode returned code from LDAP.
>>>
>>> LS
>>>
>>>
>>
>> ACK.
>>
>> CI link:
>> http://sssd-ci.duckdns.org/logs/job/17/89/summary.html
>>
>> Michal
>
> Thanks.
>
> What about adding a default: to the switch? I know we currently can't
> get any other value, but it would be better to error out in that case.

I do not think the default label is necessary, the code will get there
only if sdap_ret is EOK or ENOENT (see few lines above the switch
if (ret && ret != ENOENT)).
But I am OK with adding it there if you think it will make the code
nicer.

Michal




More information about the sssd-devel mailing list