[SSSD] [PATCH] Update few debug messages

Pavel Reichl preichl at redhat.com
Fri Jun 19 10:53:49 UTC 2015


On 06/19/2015 10:46 AM, Lukas Slebodnik wrote:
> On (19/06/15 10:37), Pavel Reichl wrote:
>> On 06/18/2015 06:16 PM, Lukas Slebodnik wrote:
>>> ehlo,
>>>
>>> I noticed the same noise in log files as user in ticker 2678.
>>> It was a little bit related to the latest changes with setting
>>> initgroups flag in the right time.
>>>
>>> LS
>>>
>>>
>> Hello,
>> the patch won't apply on current master. Does it depend on some patch which
>> is being reviewed?
> Yes,
> It is related to "[PATCH] SDAP: Remove user from cache for missing user in
> LDAP". I didn't send them together because this patch does not fix regression.
>
> LS
OK thanks, the only nitpick I found is usage of strerror, I know that 
Michal has patch to change this globally but I think that we are in 
agreement to use sss_strerror in changed/new code anyway, right?
> +                } else if (ret != ENOENT) {
>                      DEBUG(SSSDBG_OP_FAILURE,
> -                          "sysdb_search_object_by_uuid did not return 
> a " \
> -                          "single result.\n");
> +                          "sysdb_search_object_by_uuid failed or 
> returned "
> +                          "more than one result [%d][%s].\n",
> +                          ret, strerror(ret));

Otherwise code LGTM and CI passed, but I assume that I can't ack before 
"[PATCH] SDAP: Remove user from cache for missing user in LDAP" gets 
pushed to master anyway.

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list