[SSSD] [PATCH] IPA: Don't override homedir with subdomain_homedir

Pavel Reichl preichl at redhat.com
Fri Jun 5 15:07:39 UTC 2015


On 06/05/2015 04:44 PM, Michal Židek wrote:
> On 06/05/2015 01:33 PM, Pavel Reichl wrote:
>> On 06/05/2015 01:17 PM, Michal Židek wrote:
>>> On 05/28/2015 06:43 PM, Pavel Reichl wrote:
>>>> Hello,
>>>>
>>>> please see simple attached patch.
>>>>
>>>> Thanks!
>>>>
>>>>
>>>
>>> Please send version that cleanly applies on top of current master.
>>>
>>> Michal
>>>
>>> _______________________________________________
>>> sssd-devel mailing list
>>> sssd-devel at lists.fedorahosted.org
>>> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>> Hello,
>>
>> please see rebased patch attached.
>>
>> Thanks!
>>
>
> Super small nitpick:
>  static errno_t
>  get_subdomain_homedir_of_user(TALLOC_CTX *mem_ctx, struct 
> sss_domain_info *dom,
>                                const char *fqname, uint32_t uid,
> -                              const char **_homedir)
> +                              const char* original, const char
>                                      ^^^^^
> Could you please move the '*' to the 'original' to look like
> const char *original?
Sure.
>
> The patch passed my testing. 
I suppose you have  read the testing section from design document, right?
> The only thing that did not work for me
> was from sssd client when the server was not patched, but I think this
> is expected (please confirm).
I hereby confirm that this is expected behavior.
>
> I am waiting for the CI to finish.
>
> Michal
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-IPA-Don-t-override-homedir-with-subdomain_homedir.patch
Type: text/x-patch
Size: 4814 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150605/e963d583/attachment.bin>


More information about the sssd-devel mailing list