[SSSD] [PATCH] Make it possible to inherit ignore_group_members, ldap_purge_cache_timeout and ldap_use_tokengroups into subdomains

Pavel Reichl preichl at redhat.com
Wed Jun 3 16:04:36 UTC 2015


5th patch)
>>> +static void sdap_inherit_user_options(struct sss_domain_info *parent_dom,
>>> +                                      struct sdap_attr_map
>>> *parent_user_map,
>>> +                                      struct sdap_attr_map
>>> *child_user_map)
>>> +{
>>> +    int inherit_options[] = {
>>> +        SDAP_AT_USER_PRINC,
>>> +        SDAP_OPTS_USER          /* sentinel */
>>> +    };
>>> +    int i;
>>> +
>>> +    for (i = 0; inherit_options[i] != SDAP_OPTS_USER; i++) {
>>> +        sdap_copy_map_entry(parent_user_map, child_user_map, i);
>> s/i/inherit_options[i] ?
> No, the parameter is an integer.
>
Yes, it's integer - I'd expect that you want to call:

sdap_copy_map_entry(parent_user_map, child_user_map, SDAP_AT_USER_PRINC) rather then sdap_copy_map_entry(parent_user_map, child_user_map, 0)

I don't see what's the point of values of inherit_options at all if the code would be right...I'll have another look tomorrow with fresh eyes.

Jakub it must be a typo - I can't resolve user from subdomain with patches applied, but if I do the proposed change resolving of subdomain users starts to work.


>
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150603/b0b31368/attachment.html>


More information about the sssd-devel mailing list