[SSSD] [PATCH] SDAP: Check return value before using output arguments

Lukas Slebodnik lslebodn at redhat.com
Mon Jun 1 10:56:01 UTC 2015


On (01/06/15 10:40), Pavel Reichl wrote:
>On 05/30/2015 04:52 PM, Lukas Slebodnik wrote:
>>ehlo,
>>
>>simple patch is attached.
>>
>>LS
>>
>>
>LGTM, ci passed:
>sssd-ci.duckdns.org/logs/job/16/47/summary.html
>
>You might consider changing:
>        if (debug_level & SSSDBG_TRACE_ALL) {
>in the very same fuction to IS_DEBUG_SET, but I don't insist.
Could you explain how it is related to the patch?
The title is "Check return value before using output arguments"

The patch should do what it is written in commit message.
Irrelevant changes should be in different patch.

LS



More information about the sssd-devel mailing list