[SSSD] [PATCH] mmap_cache: "Override" functions for initgr mmap cache

Michal Židek mzidek at redhat.com
Fri Jul 31 15:07:48 UTC 2015


On 07/31/2015 04:54 PM, Michal Židek wrote:
> On 07/30/2015 05:23 PM, Michal Židek wrote:
>> On 07/30/2015 05:06 PM, Michal Židek wrote:
>>> On 07/30/2015 04:15 PM, Lukas Slebodnik wrote:
>>>> On (29/07/15 17:05), Lukas Slebodnik wrote:
>>>>> Attached is a new patch set. I also contains fix for #2712 and not
>>>>> just for
>>>>> #2716. Otherwise there would be a crash. So it would be better
>>>>> push them together.
>>>>>
>>>>
>>>> Integration test were failing sporadically due to bug in clien code.
>>>> 3rd patch fix this problem.
>>>>
>>>> Other patches are the same.
>>>>
>>>> LS
>>>>
>>>
>>> Integration tests still do not work for me even with
>>> this version.
>>>
>>> $ contrib/ci/run -n -r
>>> autoreconf:             success  00:00:14 ci-autoreconf.log
>>> DEBUG BUILD:                              ci-build-debug
>>> configure:              success  00:00:10
>>> ci-build-debug/ci-configure.log
>>> make-tests:             success  00:02:18
>>> ci-build-debug/ci-make-tests.log
>>> make-check-valgrind:    success  00:01:41
>>> ci-build-debug/ci-make-check-valgrind.log
>>> make-intgcheck:         failure  00:01:55
>>> ci-build-debug/ci-make-intgcheck.log
>>> FAILURE
>>>
>>> See sanitized log. These are the newly added _with_mc tests.
>>>
>>> Michal
>>>
>>
>> Ah... nevermind, I had exported SSS_NSS_USE_MEMCACHE=no in
>> the terminal where I was running the tests.
>>
>
> On the other hand this proves that your tests really
> catch situation when memcache does not work :)
>
> Thank you for expanding the tests coverage.
>
> Tentative ACK to the patches (will fully ack when
> CI results finish).
>
> I filled a ticket to track one issue,
> but it does not seem to be related to the memcache.
> https://fedorahosted.org/sssd/ticket/2741
>

Well, it is related to the memcache. But not that
memcache itself would not work. We somewhere miss
call to clear the memcache in the code branch
that 'su' triggers.

Michal

-- 
Senior Principal Intern



More information about the sssd-devel mailing list