[SSSD] [PATCHES] Add support for Smartcard authentication

Jakub Hrozek jhrozek at redhat.com
Wed Jul 29 13:34:32 UTC 2015


On Tue, Jul 28, 2015 at 10:43:13PM +0200, Sumit Bose wrote:
> > 
> > Hi,
> > 
> > I started the review, but because the patches are quite big, I will send
> > my comments in batches. I hope that's fine.
> 
> Thank you for the review.
> 
> > 
> > CI failed in distcheck.
> 
> The failure was due to distcheck's tendency to make the complete source
> tree read-only and NSS's tendency open all databases in read-write more.
> I added the needed read-onl options to the NSS code.
> 
> > 
> > Coverity found some issues that I forwarded to Sumit.
> 
> Thank you, I fixed them and hopefully did not create new ones.

Coverity is clean this time, but CI did not pass on Debian due to build
failure of a test:
    http://sssd-ci.duckdns.org/logs/job/19/78/debian_testing/ci-build-debug/ci-make-tests.log
Normally this is caused by a missing dependency, which the Fedora/RHEL
linker can satisfy.

I will review the rest of the patches.



More information about the sssd-devel mailing list