[SSSD] [PATCH] TESTS: fix compiler warnings

Lukas Slebodnik lslebodn at redhat.com
Tue Jul 28 10:29:23 UTC 2015


On (28/07/15 10:46), Pavel Reichl wrote:
>
>
>On 07/28/2015 10:28 AM, Lukas Slebodnik wrote:
>>On (28/07/15 10:16), Pavel Reichl wrote:
>>>Hello, please see trivial patch attached which fixes compiler warnings:
>>>
>>[snip]
>>ACK for unused variables
>>NACK for discard_const
>>  It's beeter to change type of view_name from "char *" -> "const char *"
>>
>I didn't want to change the code outside of tests without testing, but I
>assume that if it compiles after such change then it's fine...
>
There was an assumtion that problem is in test. It wasn't right.
It's better to avoid explicit casting and discard_const is explicit casting.

>From 8ea2ba3a739960c7bba225c2d5cf85f61b358307 Mon Sep 17 00:00:00 2001
>From: Pavel Reichl <preichl at redhat.com>
>Date: Tue, 28 Jul 2015 04:12:48 -0400
>Subject: [PATCH] TESTS: fix compiler warnings
>
>---
> src/confdb/confdb.h                 | 2 +-
> src/tests/cmocka/test_sysdb_views.c | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/src/confdb/confdb.h b/src/confdb/confdb.h
>index 36df6aea268cc5c82696f20b1a65963350d5e100..0b0ae0dcf2cd26462a9b0c895d833faf5c85b4e5 100644
ACK

http://sssd-ci.duckdns.org/logs/job/19/67/summary.html

LS



More information about the sssd-devel mailing list