[SSSD] [PATCH] intg_test: Add integration test for memory cache

Sumit Bose sbose at redhat.com
Fri Jul 24 14:19:12 UTC 2015


On Fri, Jul 24, 2015 at 03:35:22PM +0200, Lukas Slebodnik wrote:
> ehlo,
> 
> it is a first version of integration test for memory cache.
> The main purpose of this mail is to have some comments to the first version.
> cwrap doesn't support properly initgroups therefore I used a ctype module
> for calling initgroups from libnsss_sss.so.

I don't mind calling initgroups from libnsss_sss.so but I think
initgroups() support in cwrap is not strictly needed here. Since the
initgroups() call does not return any groups you would need a
combination of initgroups() and getgroups() in the tests.

getgrouplist() will return directly the list of groups for a given user
and is already supported in cmocka. Unfortunately it looks like the
corresponding Python inferface os.getgrouplist is only added in 3.3.

bye,
Sumit

> 
> I'm aware of some issies in this patch: wildcard import, function for calling
> sssd initgroups can be moved to separate module ...
> 
> You might need a patch from thread "[SSSD] [PATCH] intg: Invalidate memory
> cache before removing files" to have all gree tests.
> 
> I'm also attaching a two tests which fails. It is a known bugs with memory
> cache. It just for showing that attached patch is really testing sometning :-)
> 
> Please provide any comments which can improve this tests.
> 
> LS



More information about the sssd-devel mailing list