[SSSD] [PATCH] Update few debug messages

Lukas Slebodnik lslebodn at redhat.com
Thu Jul 16 12:54:39 UTC 2015


On (16/07/15 14:35), Pavel Reichl wrote:
>On 07/14/2015 01:21 PM, Lukas Slebodnik wrote:
>>+++ b/src/db/sysdb_search.c
>>@@ -1613,10 +1613,11 @@ errno_t sysdb_get_real_name(TALLOC_CTX *mem_ctx,
>>                                                    &res);
>>                  if (ret == EOK && res->count == 1) {
>>                      msg = res->msgs[0];
>>-                } else {
>>+                } else if (ret != ENOENT) {
>>                      DEBUG(SSSDBG_OP_FAILURE,
>>-                          "sysdb_search_object_by_uuid did not return a " \
>>-                          "single result.\n");
>>+                          "sysdb_search_object_by_uuid failed or returned "
>>+                          "more than one result [%d][%s].\n",
>>+                          ret, strerror(ret));
>Hello,
>
>I asked you to replace 'strerror' by 'sss_strerror'. But I don't think it's
>too important. Local CI passed, so ACK.
>
Just one message contained sss_strerror. It might have been caused by
improper merging after rebase.

Thank you for a careful review and updated version is attached.

LS
-------------- next part --------------
>From 558088b8f271a58fad85159173cbeec8ac982a0c Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Tue, 14 Jul 2015 13:16:39 +0200
Subject: [PATCH] Update few debug messages

It reduces a noise caused by canonicalization of non-existing user.

Resolves:
https://fedorahosted.org/sssd/ticket/2678
---
 src/db/sysdb_search.c        | 7 ++++---
 src/providers/ldap/ldap_id.c | 5 +++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/db/sysdb_search.c b/src/db/sysdb_search.c
index 4f617b841bf3b3760d9cb05a06f4b46ea0c58ff5..5f33b225a31e1c1add7f776215d500fb09e127ca 100644
--- a/src/db/sysdb_search.c
+++ b/src/db/sysdb_search.c
@@ -1707,10 +1707,11 @@ errno_t sysdb_get_real_name(TALLOC_CTX *mem_ctx,
                                                   &res);
                 if (ret == EOK && res->count == 1) {
                     msg = res->msgs[0];
-                } else {
+                } else if (ret != ENOENT) {
                     DEBUG(SSSDBG_OP_FAILURE,
-                          "sysdb_search_object_by_uuid did not return a " \
-                          "single result.\n");
+                          "sysdb_search_object_by_uuid failed or returned "
+                          "more than one result [%d][%s].\n",
+                          ret, sss_strerror(ret));
                     ret = ENOENT;
                     goto done;
                 }
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index 73840d2885ed15a7a9dae2e9175d8361c8fdfe7d..905bbd94d36e52e212d118e728f5fe46fa5bc64a 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -1224,8 +1224,9 @@ static void groups_by_user_done(struct tevent_req *subreq)
         ret = sysdb_get_real_name(state, state->domain, state->name, &cname);
         if (ret != EOK) {
             cname = state->name;
-            DEBUG(SSSDBG_OP_FAILURE,
-                  "Failed to canonicalize name, using [%s].\n", cname);
+            DEBUG(SSSDBG_TRACE_INTERNAL,
+                  "Failed to canonicalize name, using [%s] [%d]: %s.\n",
+                  cname, ret, sss_strerror(ret));
         }
     }
 
-- 
2.4.3



More information about the sssd-devel mailing list