[SSSD] [PATCHES] Wildcard lookups for InfoPipe

Pavel Březina pbrezina at redhat.com
Wed Jul 15 09:02:51 UTC 2015


On 07/14/2015 03:18 PM, Jakub Hrozek wrote:
> On Tue, Jul 14, 2015 at 02:39:13PM +0200, Pavel Březina wrote:
>>>> *Patch #02 SYSDB: Add functions to look up multiple entries including name
>>>> and custom filter*
>>>>
>>>>> +static char *enum_filter(TALLOC_CTX *mem_ctx,
>>>>> +                         const char *base_filter,
>>>>> +                         const char *name_filter,
>>>>> +                         const char *addtl_filter)
>>>>
>>>> You are leaking memory here if any of the allocation fails. I know it will
>>>> be freed in the caller but it is not a good practice.
>>>
>>> As discussed on IRC, I added a context.
>>
>> Nack. You added a tmp_ctx but you still use mem_ctx :-)
>
> Let's try to again.
>
> This is the only change in the set.

Ack.




More information about the sssd-devel mailing list