[SSSD] [PATCHES] cache_req improvements

Pavel Březina pbrezina at redhat.com
Fri Jan 30 16:04:09 UTC 2015


On 01/27/2015 02:19 PM, Pavel Březina wrote:
> Hi,
> these patches were created as part of my dbus work however they do not
> depend on it. Those patches can be applied on top of current master and
> review separately.
>
> Recently introduced cache_req interface which hides all the logic of
> search for a sysdb object in cache and data provider supported only user
> by name and initgroups request.
>
> These patches add support also for "user by id", "group by name", "group
> by id" (for new Users and Groups IFP interfaces). It also hides
> sss_parse_inp into cache_req so the may no longer be the need to parse
> username in consumers of the API.
>
> Everything is unit tested.
>
> Happy reviewing :-)

Self nack. I was passing wrong name (input->name instead of 
input->orig_name) into sss_parse_inp which caused SIGSEGV. This was not 
caught by unit tests since the return value of sss_parse_inp is mocked.

I fixed this and renamed input->name into input->safe_name to avoid 
another name confusion.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cache_req-tests-rename-test_user-to-test_user_by_nam.patch
Type: text/x-patch
Size: 8471 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-cache_req-tests-define-user-name-constant.patch
Type: text/x-patch
Size: 4441 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-cache_req-preparations-for-different-input-type.patch
Type: text/x-patch
Size: 24526 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-cache_req-add-support-for-user-by-uid.patch
Type: text/x-patch
Size: 25496 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-cache_req-add-support-for-group-by-name.patch
Type: text/x-patch
Size: 20286 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-cache_req-remove-default-branch-from-switches.patch
Type: text/x-patch
Size: 2570 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-cache_req-add-support-for-group-by-id.patch
Type: text/x-patch
Size: 19941 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-cmocka-include-mock_parse_inp-in-header-file.patch
Type: text/x-patch
Size: 933 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-cache_req-parse-input-name-if-needed.patch
Type: text/x-patch
Size: 20002 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150130/437e7a24/attachment-0008.bin>


More information about the sssd-devel mailing list