[SSSD] [PATCH] RESOLV: Add an internal function to read TTL from a DNS packet

Pavel Březina pbrezina at redhat.com
Tue Jan 27 10:24:48 UTC 2015


On 01/21/2015 05:30 PM, Jakub Hrozek wrote:
>> It looks good otherwise. I got the following compilation error though:
>>
>>    CC     src/tests/cmocka/ifp_tests-common_mock_resp.o
>> In file included from /home/pbrezina/workspace/sssd/src/tests/common.h:31:0,
>>                   from
>> /home/pbrezina/workspace/sssd/src/tests/cmocka/common_mock.h:44,
>>                   from
>> /home/pbrezina/workspace/sssd/src/tests/cmocka/test_resolv_fake.c:35:
>> /home/pbrezina/workspace/sssd/src/providers/ldap/sdap.h:507:33: error:
>> function declaration isn’t a prototype [-Werror=strict-prototypes]
>
> This one was fun to track down. So because in the tests we use both the system
> resolver and indirectly the sdap.h include file is present, the function
> declaration resolved to:
>
> errno_t sdap_parse_deref(TALLOC_CTX *mem_ctx,
>                           struct sdap_attr_map_info *minfo,
>                           size_t num_maps,
>                           LDAPDerefRes *dref,
>                           struct sdap_deref_attrs ***(*__res_state()));
>
> I think the simplest solution is to rename the _res parameter into something else..

Nice... this is just sad.

ACK to all patches. I'm sending a rebased version in the attachement, it 
was just a simple Makefile conflict.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-LDAP-Rename-the-_res-output-parameter-to-avoid-clash.patch
Type: text/x-patch
Size: 2152 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150127/e32e67e7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-RESOLV-Add-an-internal-function-to-read-TTL-from-a-D.patch
Type: text/x-patch
Size: 23783 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150127/e32e67e7/attachment-0001.bin>


More information about the sssd-devel mailing list