[SSSD] [PATCH] LDAP: Conditional jump depends on uninitialised value

Lukas Slebodnik lslebodn at redhat.com
Mon Jan 26 17:31:05 UTC 2015


ehlo,

It haven't caused any problem yet because it is low probability that
ret != EOK && has_posix == false

"Usually, undefined value means non-zero value"

simple patch is attached.

LS
-------------- next part --------------
>From 094d48fa6163d2286a20664b81b7b955e56bfe16 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Mon, 26 Jan 2015 15:43:08 +0100
Subject: [PATCH] LDAP: Conditional jump depends on uninitialised value

==31767==    at 0x5B66CFC: users_get_posix_check_done (ldap_id.c:346)
==31767==    by 0x4DCC6AA: _tevent_req_notify_callback (tevent_req.c:112)
==31767==    by 0x4DCC724: tevent_req_finish (tevent_req.c:149)
==31767==    by 0x4DCC782: _tevent_req_error (tevent_req.c:167)
==31767==    by 0x5B7ED43: sdap_posix_check_done (sdap_async.c:2486)
==31767==    by 0x4DCC6AA: _tevent_req_notify_callback (tevent_req.c:112)
==31767==    by 0x4DCC724: tevent_req_finish (tevent_req.c:149)
==31767==    by 0x4DCC782: _tevent_req_error (tevent_req.c:167)
==31767==    by 0x5B7DE37: sdap_get_generic_op_finished (sdap_async.c:1523)
==31767==    by 0x5B7D62B: sdap_process_result (sdap_async.c:357)
==31767==    by 0x4DCFC1C: tevent_common_loop_timer_delay (tevent_timed.c:341)
==31767==    by 0x4DD0E12: epoll_event_loop_once (tevent_epoll.c:911)
==31767==    by 0x4DCF23E: std_event_loop_once (tevent_standard.c:114)
==31767==    by 0x4DCB38F: _tevent_loop_once (tevent.c:530)
==31767==    by 0x4DCB58B: tevent_common_loop_wait (tevent.c:634)
==31767==    by 0x4DCF1BE: std_event_loop_wait (tevent_standard.c:140)
==31767==    by 0x4DCB627: _tevent_loop_wait (tevent.c:653)
==31767==    by 0x489AB98: server_loop (server.c:668)
==31767==    by 0x10D035: main (data_provider_be.c:2915)
---
 src/providers/ldap/ldap_id.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index 2e58f4e49eb33a85cbb8b4144c69004c6b5b312b..affbdad957087515961177c2378d82d52bc1ef90 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -343,7 +343,7 @@ static void users_get_posix_check_done(struct tevent_req *subreq)
 
     /* If the check ran to completion, we know for certain about the attributes
      */
-    if (has_posix == false) {
+    if (ret == EOK && has_posix == false) {
         state->sdap_ret = ERR_NO_POSIX;
         tevent_req_done(req);
         return;
-- 
2.1.0



More information about the sssd-devel mailing list