[SSSD] [PATCH] MAN: Amend the description of ignore_group_members

Jakub Hrozek jhrozek at redhat.com
Wed Jan 14 16:08:03 UTC 2015


On Wed, Jan 14, 2015 at 05:02:24PM +0100, Pavel Reichl wrote:
> 
> On 01/14/2015 11:13 AM, Jakub Hrozek wrote:
> > From 6c8cee6aeb6548bfc78d1ba2979a3ba8b002c522 Mon Sep 17 00:00:00 2001
> >From: John Dickerson<jedicker at iastate.edu>
> >Date: Fri, 12 Dec 2014 10:38:10 +0100
> >Subject: [PATCH] MAN: Amend the description of ignore_group_members
> >
> >The option description should hint that enabling this option may have a
> >positive effect on access control, especially with large groups.
> Did you miss a word performance or something similar in this commit
> description?
> "positive effect on *performace* of access control?"
> 
> Applies fine, builds fine, makes sense to me.
> 
> I don't think you have to amend the description as I proposed - so ACK.

Ah, yes, I will amend the commit message before pushing.

> 
> Or do we need a native speaker to ack?

The diff was mostly written by John Dickerson, I just amended some
technicalities, so I don't think we need a native speaker here.



More information about the sssd-devel mailing list