[SSSD] [PATCH] Fix usage of talloc_steal

Lukas Slebodnik lslebodn at redhat.com
Sat Jan 10 17:12:26 UTC 2015


ehlo,

talloc_steal is a macro around function _talloc_steal_loc
and returns the pointer that you pass it. It does not have any failure modes.

If the output value is ignored there are compiler warnings.

Example of warning
src/util/util.c:503:164: warning: expression result unused [-Wunused-value]
        ({ __typeof__(internal_ctx) __talloc_steal_ret = (__typeof__(internal_ctx))_talloc_steal_loc((table),(internal_ctx), "../sssd/src/util/util.c" ":" "503"); __talloc_steal_ret; });
                                                                                                                                                                   ^~~~~~~~~~~~~~~~~~
1 warning generated.


I am opened to better solution of this warning.

LS
-------------- next part --------------
>From 0ece596b9d9c93d38449143364345f50790cafa6 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Mon, 15 Sep 2014 16:27:08 +0200
Subject: [PATCH 3/3] Fix usage of talloc_steal

talloc_steal is a macro around function _talloc_steal_loc
and returns the pointer that you pass it. It does not have any failure modes.

If the output value is ignored there are compiler warnings.

Example of warning
src/util/util.c:503:164: warning: expression result unused [-Wunused-value]
        ({ __typeof__(internal_ctx) __talloc_steal_ret = (__typeof__(internal_ctx))_talloc_steal_loc((table),(internal_ctx), "../sssd/src/util/util.c" ":" "503"); __talloc_steal_ret; });
                                                                                                                                                                   ^~~~~~~~~~~~~~~~~~
1 warning generated.
---
 src/db/sysdb.c                                |  4 ++--
 src/ldb_modules/memberof.c                    | 10 +++++-----
 src/monitor/monitor.c                         |  2 +-
 src/providers/ad/ad_gpo_child.c               |  2 +-
 src/providers/ad/ad_srv.c                     |  4 ++--
 src/providers/data_provider_be.c              |  2 +-
 src/providers/data_provider_callbacks.c       |  2 +-
 src/providers/dp_dyndns.c                     |  8 ++++----
 src/providers/dp_refresh.c                    |  2 +-
 src/providers/ipa/ipa_common.c                |  2 +-
 src/providers/ipa/ipa_hbac_services.c         |  2 +-
 src/providers/ipa/ipa_hosts.c                 |  2 +-
 src/providers/ipa/selinux_child.c             |  2 +-
 src/providers/krb5/krb5_child.c               |  2 +-
 src/providers/krb5/krb5_common.c              |  4 ++--
 src/providers/ldap/ldap_child.c               |  2 +-
 src/providers/ldap/ldap_common.c              |  4 ++--
 src/providers/ldap/ldap_id_cleanup.c          |  2 +-
 src/providers/ldap/ldap_id_enum.c             |  2 +-
 src/providers/ldap/sdap_async_groups.c        |  2 +-
 src/providers/ldap/sdap_async_initgroups.c    | 10 +++++-----
 src/providers/ldap/sdap_async_nested_groups.c |  4 ++--
 src/providers/ldap/sdap_async_netgroups.c     |  2 +-
 src/providers/ldap/sdap_async_users.c         |  2 +-
 src/providers/ldap/sdap_sudo.c                |  4 ++--
 src/providers/proxy/proxy_auth.c              |  2 +-
 src/responder/autofs/autofssrv_cmd.c          |  2 +-
 src/responder/nss/nsssrv_netgroup.c           |  2 +-
 src/responder/pac/pacsrv_cmd.c                |  2 +-
 src/responder/ssh/sshsrv_cmd.c                |  4 ++--
 src/responder/sudo/sudosrv_get_sudorules.c    |  4 ++--
 src/sbus/sssd_dbus_connection.c               |  2 +-
 src/util/util.c                               |  2 +-
 33 files changed, 52 insertions(+), 52 deletions(-)

diff --git a/src/db/sysdb.c b/src/db/sysdb.c
index 61a2240016b5cb77e6fbbc3286fd1a194c5a0b48..bbeafc5ad248cd1b3e9ce5c6e6aa0af1d94178e5 100644
--- a/src/db/sysdb.c
+++ b/src/db/sysdb.c
@@ -112,7 +112,7 @@ struct ldb_dn *sysdb_custom_subtree_dn(TALLOC_CTX *mem_ctx,
     dn = ldb_dn_new_fmt(tmp_ctx, dom->sysdb->ldb, SYSDB_TMPL_CUSTOM_SUBTREE,
                         clean_subtree, dom->name);
     if (dn) {
-        talloc_steal(mem_ctx, dn);
+        (void) talloc_steal(mem_ctx, dn);
     }
     talloc_free(tmp_ctx);
 
@@ -643,7 +643,7 @@ int sysdb_attrs_steal_string(struct sysdb_attrs *attrs,
     el->values = vals;
 
     /* now steal and assign the string */
-    talloc_steal(el->values, str);
+    (void) talloc_steal(el->values, str);
 
     el->values[el->num_values].data = (uint8_t *)str;
     el->values[el->num_values].length = strlen(str);
diff --git a/src/ldb_modules/memberof.c b/src/ldb_modules/memberof.c
index 995c382a8ee36bfc010f2761010db1fb48343d5d..8b3bf1de3b9f81f26ceac7a07d23019d8f244edd 100644
--- a/src/ldb_modules/memberof.c
+++ b/src/ldb_modules/memberof.c
@@ -957,7 +957,7 @@ static int mbof_add_operation(struct mbof_add_operation *addop)
     if (ret != LDB_SUCCESS) {
         return ret;
     }
-    talloc_steal(mod_req, msg);
+    (void) talloc_steal(mod_req, msg);
 
     return ldb_next_request(ctx->module, mod_req);
 }
@@ -2251,7 +2251,7 @@ static int mbof_del_mod_entry(struct mbof_del_operation *delop)
     if (ret != LDB_SUCCESS) {
         return ret;
     }
-    talloc_steal(mod_req, msg);
+    (void) talloc_steal(mod_req, msg);
 
     return ldb_next_request(ctx->module, mod_req);
 }
@@ -3889,8 +3889,8 @@ static int mbof_steal_msg_el(TALLOC_CTX *memctx,
     }
 
     *dest = *src;
-    talloc_steal(dest, dest->name);
-    talloc_steal(dest, dest->values);
+    (void) talloc_steal(dest, dest->name);
+    (void) talloc_steal(dest, dest->values);
 
     *_dest = dest;
     return LDB_SUCCESS;
@@ -4483,7 +4483,7 @@ static int mbof_rcmp_update(struct mbof_rcmp_context *ctx)
     if (ret != LDB_SUCCESS) {
         goto done;
     }
-    talloc_steal(req, msg);
+    (void) talloc_steal(req, msg);
 
     /* fire next call */
     return ldb_next_request(ctx->module, req);
diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index afefe7f11c15ad343e8a79dceeff5a89e2787add..3a44c0c19936b4d5abb11ae599f0a93ff1afe598 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -3022,7 +3022,7 @@ int main(int argc, const char *argv[])
     monitor->is_daemon = !opt_interactive;
     monitor->parent_pid = main_ctx->parent_pid;
     monitor->ev = main_ctx->event_ctx;
-    talloc_steal(main_ctx, monitor);
+    monitor = talloc_steal(main_ctx, monitor);
 
     ret = monitor_process_init(monitor,
                                config_file);
diff --git a/src/providers/ad/ad_gpo_child.c b/src/providers/ad/ad_gpo_child.c
index ceb2faeb65e797c5b8493cd4bbe95690d848f28d..681f708cc03706e4a30b0b3df044f925bf232e95 100644
--- a/src/providers/ad/ad_gpo_child.c
+++ b/src/providers/ad/ad_gpo_child.c
@@ -720,7 +720,7 @@ main(int argc, const char *argv[])
         talloc_free(discard_const(debug_prg_name));
         goto fail;
     }
-    talloc_steal(main_ctx, debug_prg_name);
+    (void) talloc_steal(main_ctx, debug_prg_name);
 
     buf = talloc_size(main_ctx, sizeof(uint8_t)*IN_BUF_SIZE);
     if (buf == NULL) {
diff --git a/src/providers/ad/ad_srv.c b/src/providers/ad/ad_srv.c
index 53d8a87701705654318845eaa4e4eac9ff6a5951..6e639f99fbb2f9dabfb277279db8b576a0df0e35 100644
--- a/src/providers/ad/ad_srv.c
+++ b/src/providers/ad/ad_srv.c
@@ -88,13 +88,13 @@ static errno_t ad_sort_servers_by_dns(TALLOC_CTX *mem_ctx,
              * next priority */
             for (j = 0; j < in_index; j++) {
                 out[srv_index] = in_domain[j];
-                talloc_steal(out, out[srv_index].host);
+                (void) talloc_steal(out, out[srv_index].host);
                 srv_index++;
             }
 
             for (j = 0; j < out_index; j++) {
                 out[srv_index] = out_domain[j];
-                talloc_steal(out, out[srv_index].host);
+                (void) talloc_steal(out, out[srv_index].host);
                 srv_index++;
             }
 
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index 95df2d9c645025a47176a9956e6069ec53dc2391..6f4b2a7f61d81c73d437258aa73dbf1469c8155d 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -302,7 +302,7 @@ static errno_t be_spy_create(TALLOC_CTX *mem_ctx, struct be_req *be_req)
      * will be guaranteed that this data will be
      * available for the full duration of execution.
      */
-    talloc_steal(mem_ctx, be_req);
+    (void) talloc_steal(mem_ctx, be_req);
 
     ret = EOK;
 done:
diff --git a/src/providers/data_provider_callbacks.c b/src/providers/data_provider_callbacks.c
index 327d41f1bd43da9d1e0c026d1c62588540190730..d6e34610b414eed26ff1b92ba546e3ff27e22b2c 100644
--- a/src/providers/data_provider_callbacks.c
+++ b/src/providers/data_provider_callbacks.c
@@ -115,7 +115,7 @@ final:
     /* Steal the timer event onto the be_ctx so it doesn't
      * get freed with the cb_ctx
      */
-    talloc_steal(cb_ctx->be, te);
+    (void) talloc_steal(cb_ctx->be, te);
     talloc_free(cb_ctx);
 }
 
diff --git a/src/providers/dp_dyndns.c b/src/providers/dp_dyndns.c
index f7385d5a7f6be0d8f2a7fd248edf69175f411baa..0ca95b824058ae46aa6f8babb235c6d5085f11e3 100644
--- a/src/providers/dp_dyndns.c
+++ b/src/providers/dp_dyndns.c
@@ -68,7 +68,7 @@ sss_iface_addr_add(TALLOC_CTX *mem_ctx, struct sss_iface_addr **list,
     }
 
     /* steal old dlist to the new head */
-    talloc_steal(address, *list);
+    (void) talloc_steal(address, *list);
     DLIST_ADD(*list, address);
 
     return address;
@@ -217,7 +217,7 @@ sss_iface_addr_list_get(TALLOC_CTX *mem_ctx, const char *ifname,
             }
 
             /* steal old dlist to the new head */
-            talloc_steal(address, addrlist);
+            (void) talloc_steal(address, addrlist);
             DLIST_ADD(addrlist, address);
         }
     }
@@ -654,11 +654,11 @@ nsupdate_get_addrs_done(struct tevent_req *subreq)
         }
 
         if (state->addrlist) {
-            talloc_steal(state->addrlist, addr);
+            (void) talloc_steal(state->addrlist, addr);
         }
 
         /* steal old dlist to the new head */
-        talloc_steal(addr, state->addrlist);
+        (void) talloc_steal(addr, state->addrlist);
         DLIST_ADD(state->addrlist, addr);
     }
     state->count += count;
diff --git a/src/providers/dp_refresh.c b/src/providers/dp_refresh.c
index 817b6213ca47bba3fa34ce28fdcd1621d349b651..24b7bcaddd5adfab4db9f58fa8ef6f76eec6b71f 100644
--- a/src/providers/dp_refresh.c
+++ b/src/providers/dp_refresh.c
@@ -268,7 +268,7 @@ static errno_t be_refresh_step(struct tevent_req *req)
     }
 
     /* make the list disappear with subreq */
-    talloc_steal(subreq, values);
+    (void) talloc_steal(subreq, values);
 
     tevent_req_set_callback(subreq, be_refresh_done, req);
 
diff --git a/src/providers/ipa/ipa_common.c b/src/providers/ipa/ipa_common.c
index 2940a42cc8d1eeb0dc18289bbe14d0effcc2be91..830694b862541b7bff3d1637380401ec32153b76 100644
--- a/src/providers/ipa/ipa_common.c
+++ b/src/providers/ipa/ipa_common.c
@@ -885,7 +885,7 @@ static errno_t _ipa_servers_init(struct be_ctx *ctx,
     /* now for each one add a new server to the failover service */
     for (i = 0; list[i]; i++) {
 
-        talloc_steal(service, list[i]);
+        (void) talloc_steal(service, list[i]);
 
         if (be_fo_is_srv_identifier(list[i])) {
             if (!primary) {
diff --git a/src/providers/ipa/ipa_hbac_services.c b/src/providers/ipa/ipa_hbac_services.c
index 3040ce68a68520d7eee0ec478ee0adbfb80eb083..779184c88a631e77fe70470bc1e366eaef87a735 100644
--- a/src/providers/ipa/ipa_hbac_services.c
+++ b/src/providers/ipa/ipa_hbac_services.c
@@ -370,7 +370,7 @@ ipa_hbac_service_info_recv(struct tevent_req *req,
     *services = talloc_steal(mem_ctx, state->services);
     for (c = 0; c < state->service_count; c++) {
         /* Guarantee the memory heirarchy of the list */
-        talloc_steal(state->services, state->services[c]);
+        (void) talloc_steal(state->services, state->services[c]);
     }
 
     *servicegroup_count = state->servicegroup_count;
diff --git a/src/providers/ipa/ipa_hosts.c b/src/providers/ipa/ipa_hosts.c
index 64f80f082cdda57949e1b01efe46d6f76faa1734..d2bf9cfaeb53b16624bed933c7fd7f8e38c7ce35 100644
--- a/src/providers/ipa/ipa_hosts.c
+++ b/src/providers/ipa/ipa_hosts.c
@@ -447,7 +447,7 @@ errno_t ipa_host_info_recv(struct tevent_req *req,
     *hosts = talloc_steal(mem_ctx, state->hosts);
     for (c = 0; c < state->host_count; c++) {
         /* Guarantee the memory heirarchy of the list */
-        talloc_steal(state->hosts, state->hosts[c]);
+        (void) talloc_steal(state->hosts, state->hosts[c]);
     }
 
     if (hostgroup_count) *hostgroup_count = state->hostgroup_count;
diff --git a/src/providers/ipa/selinux_child.c b/src/providers/ipa/selinux_child.c
index cb6f96415690c3931be52167b6ccb7f081a52a6f..2b99ea0175acca4d7dfa5e504906d4ec54067761 100644
--- a/src/providers/ipa/selinux_child.c
+++ b/src/providers/ipa/selinux_child.c
@@ -205,7 +205,7 @@ int main(int argc, const char *argv[])
         talloc_free(discard_const(debug_prg_name));
         goto fail;
     }
-    talloc_steal(main_ctx, debug_prg_name);
+    (void) talloc_steal(main_ctx, debug_prg_name);
 
     buf = talloc_size(main_ctx, sizeof(uint8_t)*IN_BUF_SIZE);
     if (buf == NULL) {
diff --git a/src/providers/krb5/krb5_child.c b/src/providers/krb5/krb5_child.c
index e5ce50be4bb088df3c45e5f642e8b3f3608c4662..bb449e8b8aff0f2fbde091927ec3f8f93c2adae2 100644
--- a/src/providers/krb5/krb5_child.c
+++ b/src/providers/krb5/krb5_child.c
@@ -2388,7 +2388,7 @@ int main(int argc, const char *argv[])
         ret = ENOMEM;
         goto done;
     }
-    talloc_steal(kr, debug_prg_name);
+    (void) talloc_steal(kr, debug_prg_name);
 
     kr->fast_uid = fast_uid;
     kr->fast_gid = fast_gid;
diff --git a/src/providers/krb5/krb5_common.c b/src/providers/krb5/krb5_common.c
index 81d4048b63dba98706bbef1936df7f10f79e1ae5..ac53786c4f9d831d334048d44daa8cae95617642 100644
--- a/src/providers/krb5/krb5_common.c
+++ b/src/providers/krb5/krb5_common.c
@@ -611,7 +611,7 @@ static errno_t _krb5_servers_init(struct be_ctx *ctx,
     }
 
     for (i = 0; list[i]; i++) {
-        talloc_steal(service, list[i]);
+        (void) talloc_steal(service, list[i]);
         server_spec = talloc_strdup(service, list[i]);
         if (!server_spec) {
             ret = ENOMEM;
@@ -992,7 +992,7 @@ errno_t krb5_install_sigterm_handler(struct tevent_context *ev,
         talloc_free(sig_realm);
         return ENOMEM;
     }
-    talloc_steal(sige, sig_realm);
+    (void) talloc_steal(sige, sig_realm);
 
     return EOK;
 }
diff --git a/src/providers/ldap/ldap_child.c b/src/providers/ldap/ldap_child.c
index e9aebf5a6319b5d848aadfb27061099fc153a7f6..3b004b85e6abe46d133fce467bce2cec22b673ac 100644
--- a/src/providers/ldap/ldap_child.c
+++ b/src/providers/ldap/ldap_child.c
@@ -638,7 +638,7 @@ int main(int argc, const char *argv[])
         talloc_free(discard_const(debug_prg_name));
         goto fail;
     }
-    talloc_steal(main_ctx, debug_prg_name);
+    (void) talloc_steal(main_ctx, debug_prg_name);
 
     buf = talloc_size(main_ctx, sizeof(uint8_t)*IN_BUF_SIZE);
     if (buf == NULL) {
diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
index 8133431cc35f008768484b43cf7926d41fa0b2e0..63cc9ff0020470ab359f30de2f7a4e37c4edc983 100644
--- a/src/providers/ldap/ldap_common.c
+++ b/src/providers/ldap/ldap_common.c
@@ -200,7 +200,7 @@ errno_t sdap_install_sigterm_handler(TALLOC_CTX *mem_ctx,
         talloc_free(sig_realm);
         return ENOMEM;
     }
-    talloc_steal(sige, sig_realm);
+    (void) talloc_steal(sige, sig_realm);
 
     return EOK;
 }
@@ -558,7 +558,7 @@ static errno_t _sdap_urls_init(struct be_ctx *ctx,
 
         DEBUG(SSSDBG_TRACE_FUNC, "Added URI %s\n", list[i]);
 
-        talloc_steal(service, list[i]);
+        (void) talloc_steal(service, list[i]);
 
         /* It could be ipv6 address in square brackets. Remove
          * the brackets if needed. */
diff --git a/src/providers/ldap/ldap_id_cleanup.c b/src/providers/ldap/ldap_id_cleanup.c
index f78d4b4044598f546e0921ab27678d5a165d2d91..32d6142e185756040043bd1611f6add14f03a905 100644
--- a/src/providers/ldap/ldap_id_cleanup.c
+++ b/src/providers/ldap/ldap_id_cleanup.c
@@ -96,7 +96,7 @@ errno_t ldap_setup_cleanup(struct sdap_id_ctx *id_ctx,
         goto done;
     }
 
-    talloc_steal(sdom->cleanup_task, cleanup_ctx);
+    (void) talloc_steal(sdom->cleanup_task, cleanup_ctx);
     ret = EOK;
 
 done:
diff --git a/src/providers/ldap/ldap_id_enum.c b/src/providers/ldap/ldap_id_enum.c
index 13d2a62544b3956165ef9eb480fb5b813c890fd4..389fe680c9ddf0a5fd57c8fa890b256896ba3eba 100644
--- a/src/providers/ldap/ldap_id_enum.c
+++ b/src/providers/ldap/ldap_id_enum.c
@@ -91,7 +91,7 @@ errno_t ldap_setup_enumeration(struct be_ctx *be_ctx,
         return ret;
     }
 
-    talloc_steal(sdom->enum_task, ectx);
+    (void) talloc_steal(sdom->enum_task, ectx);
     return EOK;
 }
 
diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c
index c86b5c6b59a4de7e945b95cafae9149f681e2e18..e38ab3e7d0e2bc3544a132c725f24d54a963ecb7 100644
--- a/src/providers/ldap/sdap_async_groups.c
+++ b/src/providers/ldap/sdap_async_groups.c
@@ -787,7 +787,7 @@ static int sdap_save_group(TALLOC_CTX *memctx,
         *_usn_value = talloc_steal(memctx, usn_value);
     }
 
-    talloc_steal(memctx, group_attrs);
+    (void) talloc_steal(memctx, group_attrs);
     ret = EOK;
 
 done:
diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index d3e080013ec99c18648c6a57e478d50eb3b666f1..ad3ed64e58de491f4d018e6867a69c407a9baa95 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -894,8 +894,8 @@ static errno_t sdap_initgr_nested_deref_search(struct tevent_req *req)
         ret = EIO;
         goto fail;
     }
-    talloc_steal(subreq, sdap_attrs);
-    talloc_steal(subreq, maps);
+    (void) talloc_steal(subreq, sdap_attrs);
+    (void) talloc_steal(subreq, maps);
 
     tevent_req_set_callback(subreq, sdap_initgr_nested_deref_done, req);
     return EAGAIN;
@@ -2045,7 +2045,7 @@ rfc2307bis_group_memberships_build(hash_entry_t *item, void *user_data)
         goto done;
     }
 
-    talloc_steal(mstate, mdiff);
+    (void) talloc_steal(mstate, mdiff);
     DLIST_ADD(mstate->memberships, mdiff);
     ret = EOK;
 done:
@@ -2540,7 +2540,7 @@ static void rfc2307bis_nested_groups_process(struct tevent_req *subreq)
 
     /* Steal the nested group entry on the group_hash context so it can
      * outlive this request */
-    talloc_steal(state->group_hash, ngr);
+    (void) talloc_steal(state->group_hash, ngr);
 
     value.type = HASH_VALUE_PTR;
     value.ptr = ngr;
@@ -2977,7 +2977,7 @@ static void sdap_get_initgr_user(struct tevent_req *subreq)
             return;
         }
 
-        talloc_steal(subreq, orig_dn);
+        (void) talloc_steal(subreq, orig_dn);
         tevent_req_set_callback(subreq, sdap_get_initgr_done, req);
         break;
 
diff --git a/src/providers/ldap/sdap_async_nested_groups.c b/src/providers/ldap/sdap_async_nested_groups.c
index 1eba35ae8ac90acac8a2d46e8cc5f2b57e3a9256..1f8d6e4c0c295863ae6614d3030172984a091000 100644
--- a/src/providers/ldap/sdap_async_nested_groups.c
+++ b/src/providers/ldap/sdap_async_nested_groups.c
@@ -221,8 +221,8 @@ static errno_t sdap_nested_group_hash_entry(hash_table_t *table,
         return EIO;
     }
 
-    talloc_steal(table, key.str);
-    talloc_steal(table, value.ptr);
+    (void) talloc_steal(table, key.str);
+    (void) talloc_steal(table, value.ptr);
 
     return EOK;
 }
diff --git a/src/providers/ldap/sdap_async_netgroups.c b/src/providers/ldap/sdap_async_netgroups.c
index e50f2508707fbd43374d5afef7360274afb18fa6..6810191fed9fbcc899a4162a08f66b3687072f37 100644
--- a/src/providers/ldap/sdap_async_netgroups.c
+++ b/src/providers/ldap/sdap_async_netgroups.c
@@ -453,7 +453,7 @@ static errno_t netgr_translate_members_ldap_step(struct tevent_req *req)
         DEBUG(SSSDBG_CRIT_FAILURE, "sdap_get_generic_send failed.\n");
         return ENOMEM;
     }
-    talloc_steal(subreq, cn_attr);
+    (void) talloc_steal(subreq, cn_attr);
 
     tevent_req_set_callback(subreq, netgr_translate_members_ldap_done, req);
     return EAGAIN;
diff --git a/src/providers/ldap/sdap_async_users.c b/src/providers/ldap/sdap_async_users.c
index 367e3d795ddd0db5c1c2f8e57d700419f371cd15..03dc1d02e58549b0701e3ff4a0c601a169d3d0bd 100644
--- a/src/providers/ldap/sdap_async_users.c
+++ b/src/providers/ldap/sdap_async_users.c
@@ -511,7 +511,7 @@ int sdap_save_user(TALLOC_CTX *memctx,
         *_usn_value = talloc_steal(memctx, usn_value);
     }
 
-    talloc_steal(memctx, user_attrs);
+    (void) talloc_steal(memctx, user_attrs);
     ret = EOK;
 
 done:
diff --git a/src/providers/ldap/sdap_sudo.c b/src/providers/ldap/sdap_sudo.c
index edef44208b69af454da0fc906e608b91d5634e90..2895773add02d658e40f503ca6e7120ec9076db6 100644
--- a/src/providers/ldap/sdap_sudo.c
+++ b/src/providers/ldap/sdap_sudo.c
@@ -402,7 +402,7 @@ static char *sdap_sudo_build_host_filter(TALLOC_CTX *mem_ctx,
         goto done;
     }
 
-    talloc_steal(mem_ctx, filter);
+    (void) talloc_steal(mem_ctx, filter);
 
 done:
     talloc_free(tmp_ctx);
@@ -443,7 +443,7 @@ static char *sdap_sudo_get_filter(TALLOC_CTX *mem_ctx,
         goto done;
     }
 
-    talloc_steal(mem_ctx, filter);
+    (void) talloc_steal(mem_ctx, filter);
 
 done:
     talloc_free(tmp_ctx);
diff --git a/src/providers/proxy/proxy_auth.c b/src/providers/proxy/proxy_auth.c
index d85320cf64dc004fb0939ffc9acaf2656eed5d5b..f7f6f2d331c559007514c972f80d16e6e3de0e13 100644
--- a/src/providers/proxy/proxy_auth.c
+++ b/src/providers/proxy/proxy_auth.c
@@ -479,7 +479,7 @@ static void proxy_child_init_done(struct tevent_req *subreq) {
      * so that when the signal is freed, the context
      * will go with it.
      */
-    talloc_steal(sige, sig_ctx);
+    (void) talloc_steal(sige, sig_ctx);
 }
 
 static void remove_sige(struct tevent_context *ev,
diff --git a/src/responder/autofs/autofssrv_cmd.c b/src/responder/autofs/autofssrv_cmd.c
index 4c9f5cf7df091a7567107f08137f958fa191198c..6672db2e77f39b219f8f1bd47dd79db8f9195644 100644
--- a/src/responder/autofs/autofssrv_cmd.c
+++ b/src/responder/autofs/autofssrv_cmd.c
@@ -193,7 +193,7 @@ set_autofs_map(struct autofs_ctx *actx,
               "Hash error [%d][%s]", hret, hash_error_string(hret));
         return EIO;
     }
-    talloc_steal(actx->maps, map);
+    (void) talloc_steal(actx->maps, map);
     talloc_set_destructor((TALLOC_CTX *) map, autofs_map_hash_remove);
 
     return EOK;
diff --git a/src/responder/nss/nsssrv_netgroup.c b/src/responder/nss/nsssrv_netgroup.c
index 66b7f2759c88e8279747d59d2ec4c83ada8a21ba..bf0cf7e94413efb537e23206314c4880d6b33067 100644
--- a/src/responder/nss/nsssrv_netgroup.c
+++ b/src/responder/nss/nsssrv_netgroup.c
@@ -81,7 +81,7 @@ static errno_t set_netgroup_entry(struct nss_ctx *nctx,
               "Hash error [%d][%s]", hret, hash_error_string(hret));
         return EIO;
     }
-    talloc_steal(nctx->netgroups, netgr);
+    (void) talloc_steal(nctx->netgroups, netgr);
     talloc_set_destructor((TALLOC_CTX *) netgr, netgr_hash_remove);
 
     return EOK;
diff --git a/src/responder/pac/pacsrv_cmd.c b/src/responder/pac/pacsrv_cmd.c
index 07d2f0cf79b70429dc7cf2784a8e31d651e5095f..a674510ea2f0bd46ea9273a609066fb130fed7f0 100644
--- a/src/responder/pac/pacsrv_cmd.c
+++ b/src/responder/pac/pacsrv_cmd.c
@@ -161,7 +161,7 @@ static errno_t pac_add_pac_user(struct cli_ctx *cctx)
         goto done;
     }
 
-    talloc_steal(pr_ctx, pr_ctx->user_dom_sid_str);
+    (void) talloc_steal(pr_ctx, pr_ctx->user_dom_sid_str);
 
     ret = responder_get_domain_by_id(cctx->rctx, pr_ctx->user_dom_sid_str,
                                      &pr_ctx->dom);
diff --git a/src/responder/ssh/sshsrv_cmd.c b/src/responder/ssh/sshsrv_cmd.c
index e7bed3ab2df5ec63e48cc809fec6d1068625483f..313ee720e74dcac97bc75dff5de669589e36fa8b 100644
--- a/src/responder/ssh/sshsrv_cmd.c
+++ b/src/responder/ssh/sshsrv_cmd.c
@@ -446,7 +446,7 @@ ssh_host_pubkeys_format_known_host_plain(TALLOC_CTX *mem_ctx,
         talloc_free(pubkey);
     }
 
-    talloc_steal(mem_ctx, result);
+    (void) talloc_steal(mem_ctx, result);
 
 done:
     talloc_free(tmp_ctx);
@@ -524,7 +524,7 @@ ssh_host_pubkeys_format_known_host_hashed(TALLOC_CTX *mem_ctx,
         talloc_free(pubkey);
     }
 
-    talloc_steal(mem_ctx, result);
+    (void) talloc_steal(mem_ctx, result);
 
 done:
     talloc_free(tmp_ctx);
diff --git a/src/responder/sudo/sudosrv_get_sudorules.c b/src/responder/sudo/sudosrv_get_sudorules.c
index ac95877143e210da962a47143c18733eecdc9c02..5bd3ca85a876d014d808cd285452a65a5fbcbffb 100644
--- a/src/responder/sudo/sudosrv_get_sudorules.c
+++ b/src/responder/sudo/sudosrv_get_sudorules.c
@@ -440,11 +440,11 @@ errno_t sudosrv_get_rules(struct sudo_cmd_ctx *cmd_ctx)
     }
 
     if (dpreq != NULL) {
-        talloc_steal(cmd_ctx->cli_ctx, dpreq);
+        (void) talloc_steal(cmd_ctx->cli_ctx, dpreq);
     }
 
     if (cb_ctx != NULL) {
-        talloc_steal(cmd_ctx, cb_ctx);
+        (void) talloc_steal(cmd_ctx, cb_ctx);
     }
 
 done:
diff --git a/src/sbus/sssd_dbus_connection.c b/src/sbus/sssd_dbus_connection.c
index 6102ef9ae4715d36a623b802b9095ec1c99c1a39..6ec41af682011db302c3c1ce8300ee980e77b47c 100644
--- a/src/sbus/sssd_dbus_connection.c
+++ b/src/sbus/sssd_dbus_connection.c
@@ -544,7 +544,7 @@ static void sbus_handler_got_caller_id(struct tevent_req *req)
         /* If the handler uses private instance data, make
          * sure they go away when the request does
          */
-        talloc_steal(dbus_req, handler_data);
+        (void) talloc_steal(dbus_req, handler_data);
     } else {
         /* If no custom handler data is set, pass on the
          * interface data
diff --git a/src/util/util.c b/src/util/util.c
index 2acb8604ac0c2bc7b83ee578c7bbead9a7fd44b3..bdca87b076240c8232bb3975c7437a58859e50ce 100644
--- a/src/util/util.c
+++ b/src/util/util.c
@@ -500,7 +500,7 @@ errno_t sss_hash_create_ex(TALLOC_CTX *mem_ctx,
          * we talloc_free() the table
          */
         *tbl = talloc_steal(mem_ctx, table);
-        talloc_steal(table, internal_ctx);
+        (void)talloc_steal(table, internal_ctx);
         return EOK;
 
     case HASH_ERROR_NO_MEMORY:
-- 
2.1.0



More information about the sssd-devel mailing list