[SSSD] [PATCH] server-tests: do not use complex condition in assert

Pavel Březina pbrezina at redhat.com
Fri Jan 9 14:18:30 UTC 2015


On 01/09/2015 03:17 PM, Pavel Březina wrote:
> If OR is used in assert macro we never know what part of the condition
> was not met from a failure message directly.
>
> I'm seeing a failure in server-tests, because pid number of sssd process
> is greater than 0xffff, it is bigger than 100k. Where does this constant
> come from?
>
> [ RUN      ] test_run_as_root_daemon
> tmp > 0xFFFF
> /home/pbrezina/workspace/sssd/src/tests/cwrap/test_server.c:79: error:
> Failure

And now with the patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-server-tests-do-not-use-complex-condition-in-assert.patch
Type: text/x-patch
Size: 1045 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150109/8d7bc505/attachment.bin>


More information about the sssd-devel mailing list