[SSSD] [PATCH] [HBAC]: Better libhbac debuging
Pavel Reichl
preichl at redhat.com
Thu Aug 27 11:43:07 UTC 2015
On 08/26/2015 09:44 AM, Petr Cech wrote:
> +void hbac_debug_messages(const char *file, int line,
> + enum hbac_debug_level level,
> + const char *fmt, ...)
> +{
> + int loglevel = SSSDBG_UNRESOLVED;
> + int ret;
> + char *message = NULL;
> +
> + switch(level) {
> + case HBAC_DBG_FATAL:
> + loglevel = SSSDBG_FATAL_FAILURE;
> + break;
> + case HBAC_DBG_ERROR:
> + loglevel = SSSDBG_CRIT_FAILURE;
> + break;
> + case HBAC_DBG_WARNING:
> + loglevel = SSSDBG_OP_FAILURE;
> + break;
> + case HBAC_DBG_INFO:
> + loglevel = SSSDBG_MINOR_FAILURE;
> + break;
> + case HBAC_DBG_TRACE:
> + loglevel = SSSDBG_TRACE_ALL;
> + break;
> + }
Please add default here (http://www.freeipa.org/page/Coding_Style#Switch)
> +
> + va_list ap;
> + va_start(ap, fmt);
> + ret = vasprintf(&message, fmt, ap);
> + va_end(ap);
> + if (ret < 0) {
> + /* ENOMEM */
> + return;
> + }
> +
> + if (DEBUG_IS_SET(loglevel)) {
> + debug_fn(__FILE__, __LINE__, "hbac", loglevel, "[%s:%i] %s\n",
> + file, line, message);
> + }
> + free(message);
> +}
> +
More information about the sssd-devel
mailing list