[SSSD] [PATCH] UTIL: Alternative way for debug message initialisation

Lukas Slebodnik lslebodn at redhat.com
Thu Aug 27 10:52:58 UTC 2015


On (19/08/15 15:57), Michal Židek wrote:
>On 08/12/2015 01:11 PM, Lukas Slebodnik wrote:
>>ehlo,
>>
>>attached patch shoul avoid situation as in commit 7c69221077c780e62f6c536e78675f2dc1c131bc
>>The comments does not guarantee anything.
>>
>>Author: Michal Zidek <mzidek at redhat.com>
>>Date:   Tue Mar 10 17:30:48 2015 +0100
>>
>>     DEBUG: Add missing strings for error messages
>>
>>     We had more error codes than corresponding
>>     messages. Also order of two messages was wrong.
>>
>>Unfortunatelly, the index of enum do not start from 0
>>and need to be converted using SSSD_ERR_IDX. I used shorter version of
>>macro "idx". Feel free to propose nicer name.
>
>I would use the SSSD_ERR_IDX and not create an alias for it.
>I think it is always better to have properly namespaced macros
>even if the are a little longer.
>
a) the macro is not in public header.
b) SSSD_ERR_IDX significantly decrease readability

LS


More information about the sssd-devel mailing list