[SSSD] [PATCH] Remove trailing whitespace

Pavel Reichl preichl at redhat.com
Mon Aug 10 17:31:59 UTC 2015


On 08/10/2015 03:00 PM, Lukas Slebodnik wrote:
> On (10/08/15 14:54), Pavel Reichl wrote:
>> On 08/10/2015 02:52 PM, Lukas Slebodnik wrote:
>>> On (10/08/15 14:44), Pavel Reichl wrote:
>>>> Hello,
>>>>
>>>> please see trivial patch attached. I noticed some whitespace in source file,
>>>> so I did some grepping and decided to remove it as we already were almost 100
>>>> % trailing whitespace free.
>>>>
>>> I would prefer if you could write a test.
>>> So it will be checked as a part of "make check"
>> Yes, I already put on my todo list, but I consider it as independent task.
> Yes,
>
> but patch is not very useful without the test.
> Because we can still accidentally add trailing white spaces.
>
> I would rather wait until you write the test then we can push them
> together.
>
> Conditional NACK
>
> LS
> _________
Please see updated patch set attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-trailing-whitespace.patch
Type: text/x-patch
Size: 8863 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150810/6cb0d1da/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-TESTS-trailing-whitespace-test.patch
Type: text/x-patch
Size: 1855 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20150810/6cb0d1da/attachment-0001.bin>


More information about the sssd-devel mailing list