[SSSD] [PATCH] Don't call semanage transaction unless the context has changed

Michal Židek mzidek at redhat.com
Tue Apr 14 13:18:24 UTC 2015


On 04/10/2015 03:24 PM, Jakub Hrozek wrote:
> Hi,
>
> the attached patches fix ticket
> https://fedorahosted.org/sssd/ticket/2624
>
> It turns out that calling libsemanage transactions is a fairly intensive
> operation that involves copying multiple files under the /etc/selinux
> hierarchy to a temporary subtree and then back. With the patches, the
> context from IPA is checked against the local database first and only
> applied if it differs.
>

Hi,

the patches look good, but you used talloc_strdup in
libsss_semanage and dlopen test failed.

src/tests/dlopen-tests.c:149:F:dlopen:test_dlopen_base:0: Error opening 
libsss_semanage.so: [dlopen() failed: 
/home/user/gitrepo/sssd/.libs/libsss_semanage.so: undefined symbol: 
talloc_strdup]

I think you can feel free to link the library with talloc,
there is no particular reason for not doing so, other than
it was not needed until now. It is an "sss" internal library
so talloc will have to be around anyway.

Michal



More information about the sssd-devel mailing list