[SSSD] [PATCH] GPO: Check return value of ad_gpo_store_policy_settings

Lukas Slebodnik lslebodn at redhat.com
Wed Apr 1 06:51:27 UTC 2015


ehlo,

simple patch is attached.
It fixes warning from clang static analyzer.

LS
-------------- next part --------------
>From 80206c522c25d87bf7592259fe7d7d6ed6835470 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 6 Mar 2015 20:42:35 +0100
Subject: [PATCH] GPO: Check return value of ad_gpo_store_policy_settings

---
 src/providers/ad/ad_gpo.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index a9879b41b6b618d4c73156d95378c9bcd2b397c4..8caea392ac778e81704a9742587a89d1bbfefaf1 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -2181,6 +2181,12 @@ ad_gpo_cse_done(struct tevent_req *subreq)
      */
     ret = ad_gpo_store_policy_settings(state->domain,
                                        cse_filtered_gpo->policy_filename);
+    if (ret != EOK) {
+        DEBUG(SSSDBG_OP_FAILURE,
+              "ad_gpo_store_policy_settings failed: [%d](%s}\n",
+              ret, sss_strerror(ret));
+        goto done;
+    }
 
     state->cse_gpo_index++;
     ret = ad_gpo_cse_step(req);
-- 
2.3.4



More information about the sssd-devel mailing list