[SSSD] [PATCH v3] CI: Enforce Valgrind check

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Fri Sep 19 11:57:25 UTC 2014


On 09/18/2014 07:21 PM, Jakub Hrozek wrote:
> On Thu, Sep 18, 2014 at 04:22:12PM +0200, Lukas Slebodnik wrote:
>> On (18/09/14 10:11), Nikolai Kondrashov wrote:
>>> On 09/17/2014 07:48 PM, Lukas Slebodnik wrote:
>>>> On (17/09/14 18:48), Nikolai Kondrashov wrote:
>>>>>          stage make-check-valgrind \
>>>>>                  make-check-wrap -j $CPU_NUM check -- \
>>>>>                                  libtool --mode=execute \
>>>>> -                                    valgrind-condense 99 '!(*.py)' -- \
>>>>> +                                    valgrind-condense 99 \
>>>>> +                                    '!(*.py|*dlopen-tests)' -- \
>>>>>                                      --vgdb=no \
>>>>                                        ^^^^^^^^^
>>>>                      Why do we need to have disabled vgdb?
>>>> It is true that vgdb is enabled by default, but default value of vgdb-error is
>>>> 999999999.
>>>
>>> Yeah, it is almost impossible it will be hit. And vgdb is enabled to make it
>>> easier to enable it by lowering vgdb-error. But I'd prefer not to care about
>>> CI hanging, waiting on input for whatever reason.
>>>
>> I would prefer to remove it. It's easier to understand small code.
>> and tere are lot of other necessary options wich cannot be removed.
>
> Sounds like a fair point and an easy fix..

Sure, done.

> If there is a link, let's include it but let's not write "30 lines"
> about a bug on a stable platform. A link would be best, if there's none,
> let's go with what we have.

I included two links, as the issue is not entirely clear to me.

> The comment about status and line 203 seems valid.
>
> Let's fix these nitpicks and push the patches. Enough time was spend
> reviewing it already.

Sure.

Nick



More information about the sssd-devel mailing list