[SSSD] [PATCH v2] CI: Enforce Valgrind check

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Wed Sep 17 15:48:45 UTC 2014


On 09/17/2014 06:11 PM, Lukas Slebodnik wrote:
> On (17/09/14 17:06), Nikolai Kondrashov wrote:
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -342,7 +342,8 @@ dist_noinst_DATA = \
>>      contrib/ci/configure.sh \
>>      contrib/ci/deps.sh \
>>      contrib/ci/distro.sh \
>> -    contrib/ci/misc.sh
>> +    contrib/ci/misc.sh \
>> +    contrib/ci/sssd.supp
> We agreed to put $(NULL) at the end of list in Makefile.am
> The benefit is that with next change just one line is added instead of 2+ 1-

Sure. Updated patches attached. Thanks, Lukas.

> We don't want to do mass changes, but you touch the list, si it is the best
> time to do it.

Hmm, I noticed that we practice such approach. Is it because of the merges?

It seems to me it's just prolonging the pain and delaying the improvements.
I would personally cut it off (do the mass change) and forget about it, but I
probably never did that many merges.

Nick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-CI-Add-Valgrind-suppression-support.patch
Type: text/x-patch
Size: 2776 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140917/4da1657d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-CI-Don-t-run-dlopen-tests-under-Valgrind.patch
Type: text/x-patch
Size: 1201 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140917/4da1657d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-CI-Suppress-all-detected-Valgrind-issues.patch
Type: text/x-patch
Size: 2354 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140917/4da1657d/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-CI-Enforce-Valgrind-check.patch
Type: text/x-patch
Size: 1067 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20140917/4da1657d/attachment-0003.bin>


More information about the sssd-devel mailing list