[SSSD] [PATCH] sysdb: Write additional attrs in sysdb_add_user

Jakub Hrozek jhrozek at redhat.com
Wed Sep 17 15:26:25 UTC 2014


On Wed, Sep 17, 2014 at 05:19:48PM +0200, Daniel Gollub wrote:
> On Wed, 17 Sep 2014 05:33:17 -0700
> Jakub Hrozek <jhrozek at redhat.com> wrote:
> 
> > On Mon, Sep 01, 2014 at 10:37:53PM +0200, Daniel Gollub wrote:
> > > In the uid=0 case (to obtain new free id) only uidNumber and
> > > gidNumber attributes got written, but not the additonal provided
> > > attributes like alias or others.
> > > ---
> > >  src/db/sysdb_ops.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c
> > > index e32d79a..b1a2992 100644
> > > --- a/src/db/sysdb_ops.c
> > > +++ b/src/db/sysdb_ops.c
> > > @@ -1401,7 +1401,8 @@ int sysdb_add_user(struct sss_domain_info
> > > *domain, }
> > >  
> > >          ret = sysdb_set_user_attr(domain, name, id_attrs,
> > > SYSDB_MOD_REP);
> > > -        goto done;
> > > +        /* continue on success, to commit additional attrs */
> > > +        if (ret) goto done;
> > >      }
> > >  
> > >      if (!attrs) {
> > > -- 
> > > 1.9.1
> > 
> > Pushed to master as: 23600a657f84bbd71dca4dd77d65a1c6f4f4ff86
> 
> Thanks!
> 
> > 
> > Daniel, does the unit test I sent look good to you?
> 
> Which unit test is actually meant? The sysdb case-insensitive unit
> test one patch from today?

No, that one was for another fix. I meant this one:

https://lists.fedorahosted.org/pipermail/sssd-devel/2014-September/021620.html



More information about the sssd-devel mailing list