[SSSD] [PATCH] CI: Do not try to find memory leaks with valgrind

Simo Sorce simo at redhat.com
Wed Sep 17 13:41:56 UTC 2014


On Tue, 16 Sep 2014 23:28:04 +0200
Lukas Slebodnik <lslebodn at redhat.com> wrote:

> On (16/09/14 17:00), Simo Sorce wrote:
> >On Tue, 16 Sep 2014 21:53:56 +0200
> >Lukas Slebodnik <lslebodn at redhat.com> wrote:
> >
> >> On (02/09/14 15:38), Lukas Slebodnik wrote:
> >> >On (02/09/14 14:23), Nikolai Kondrashov wrote:
> >> >>On 09/02/2014 02:13 PM, Lukas Slebodnik wrote:
> >> >>>On (02/09/14 13:27), Nikolai Kondrashov wrote:
> >> >>>>On 09/02/2014 01:02 PM, Lukas Slebodnik wrote:
> >> >>>>>We use talloc and valgrind needn't find memory leaks.
> >> >>>>>For this purpose, we have functions in file
> >> >>>>>src/tests/leak_check.c
> >> >>>>
> >> >>>BTW
> >> >>>For tesing purposes, I reverted commit
> >> >>>d528e4960bf233bc002f9676919ede196c91564c
> >> >>
> >> >>Ah, this one is a good source of a failure.
> >> >>
> >> >>>>Thanks Lukas, this seems to work fine with the exception of
> >> >>>>this one error in refcount-tests:
> >> >>>>
> >> >>>>==2842== Syscall param timer_create(evp) points to
> >> >>>>uninitialised byte(s) ==2842==    at 0x977FE72:
> >> >>>>timer_create@@GLIBC_2.3.3 (timer_create.c:82) ==2842==    by
> >> >>>>0x4E3647B: srunner_run (in /usr/lib64/libcheck.so.0.0.0)
> >> >>>>==2842==    by 0x401616: main (refcount-tests.c:233) ==2842==
> >> >>>>Address 0xffefff460 is on thread 1's stack
> >> >>>>
> >> >Patch for this issue is on the list:
> >> >    "[PATCH] refcount-tests: Do not force to run test in CK_FORK
> >> > mode"
> >> >
> >> >I updated also readme file and new version is attached.
> >> >
> >> >This patch is blocked by ""[PATCH] refcount-tests: ..."
> >> >
> >> >LS
> >> 
> >> >From 4b20f833f71c9014b0874b5a899d71f0bdbf9ca3 Mon Sep 17 00:00:00
> >> >2001 From: Lukas Slebodnik <lslebodn at redhat.com>
> >> >Date: Tue, 2 Sep 2014 12:00:03 +0200
> >> >Subject: [PATCH] CI: Do not try to find memory leaks with valgrind
> >> >
> >> >We use talloc and valgrind needn't find memory leaks.
> >> >For this purpose, we have functions in file src/tests/leak_check.c
> >
> >We could include valgrind.h in the build and let it understand
> >talloc, we do that in samba. It is better then custom build checkers
> >usually, and avoids the need to go on the anti-pattern of creating
> >contexts on NULL.
> >
> Agree and we have already ticket for it.
> But unfortunatelly even that ticket has the highes priority there is
> no ETA. and it means that we waste time on our CI machines, becasue
> test is excuted and failures is ignored.
> 
> Currently, it is completly useless test. Nobody will notice any new
> valgrind warning. So, do we want to completly remove this test from
> suite or push the patch?

If a test is not used it should probably be temporarily disabled until
we can make use of it.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York



More information about the sssd-devel mailing list