[SSSD] [PATCH] AD: delete stale GPOs

Jakub Hrozek jhrozek at redhat.com
Mon Sep 8 17:42:56 UTC 2014


On Sun, Sep 07, 2014 at 11:29:35PM -0400, Yassir Elley wrote:
> Hi,
> 
> The attached patch fixes ticket #2431 (offline gpo processing yields incorrect results if "tattooing" occurs).
> 
> https://fedorahosted.org/sssd/ticket/2431.
> 
> Regards,
> Yassir.

The patch works as expected, but:
1) When removing a GPO fails, do you think we should fail or try to
continue?

2) Why did you decide to remove stale entries instead of removing all
and then storing the ones you found?

3) While looking at the way we store the GPOs I realized we might not be
very effective. We should look into only using one sysdb transaction for
the whole operation of modifying the cache. This clearly needs to be
done in a separate commit, though.



More information about the sssd-devel mailing list