[SSSD] [PATCH] CI: Do not try to find memory leaks with valgrind

Nikolai Kondrashov Nikolai.Kondrashov at redhat.com
Tue Sep 2 17:29:12 UTC 2014


On 09/02/2014 04:38 PM, Lukas Slebodnik wrote:
> On (02/09/14 14:23), Nikolai Kondrashov wrote:
>> On 09/02/2014 02:13 PM, Lukas Slebodnik wrote:
>>> On (02/09/14 13:27), Nikolai Kondrashov wrote:
>>>> On 09/02/2014 01:02 PM, Lukas Slebodnik wrote:
>>>>> We use talloc and valgrind needn't find memory leaks.
>>>>> For this purpose, we have functions in file src/tests/leak_check.c
>>>>
>>> BTW
>>> For tesing purposes, I reverted commit d528e4960bf233bc002f9676919ede196c91564c
>>
>> Ah, this one is a good source of a failure.
>>
>>>> Thanks Lukas, this seems to work fine with the exception of this one error
>>>> in refcount-tests:
>>>>
>>>> ==2842== Syscall param timer_create(evp) points to uninitialised byte(s)
>>>> ==2842==    at 0x977FE72: timer_create@@GLIBC_2.3.3 (timer_create.c:82)
>>>> ==2842==    by 0x4E3647B: srunner_run (in /usr/lib64/libcheck.so.0.0.0)
>>>> ==2842==    by 0x401616: main (refcount-tests.c:233)
>>>> ==2842==  Address 0xffefff460 is on thread 1's stack
>>>>
> Patch for this issue is on the list:
>      "[PATCH] refcount-tests: Do not force to run test in CK_FORK mode"
>
> I updated also readme file and new version is attached.
>
> This patch is blocked by ""[PATCH] refcount-tests: ..."

Thank you Lukas. However, this time Valgrind found some issues with
sysdb-tests on RHEL6 (with refcount-tests fixed):

==13371== Conditional jump or move depends on uninitialised value(s)
==13371==    at 0x907C968: ??? (in /lib64/libc-2.12.so)
==13371==    by 0x70E6527: sha512_crypt_r (nss_sha512crypt.c:288)
==13371==    by 0x70E67F7: s3crypt_sha512 (nss_sha512crypt.c:345)
==13371==    by 0x504FF32: sysdb_cache_auth (sysdb_ops.c:3269)
==13371==    by 0x40946E: cached_authentication_without_expiration (sysdb-tests.c:1742)
==13371==    by 0x4096D2: test_sysdb_cached_authentication_wrong_password (sysdb-tests.c:1853)
==13371==    by 0x4E3387D: srunner_run_all (in /usr/lib64/libcheck.so.0.0.0)
==13371==    by 0x405758: main (sysdb-tests.c:6103)

I reproduced them twice:
http://sssd-ci.duckdns.org/logs/job/0/32/rhel6/ci-build-debug/sysdb-tests.13371.valgrind.log
http://sssd-ci.duckdns.org/logs/job/0/33/rhel6/ci-build-debug/sysdb-tests.21003.valgrind.log

Nick



More information about the sssd-devel mailing list