[SSSD] [PATCH] CI: Do not try to find memory leaks with valgrind

Lukas Slebodnik lslebodn at redhat.com
Tue Sep 2 10:02:53 UTC 2014


ehlo,

patch is attached.

LS
-------------- next part --------------
>From 05b86de0812bd79faa40dcde51acfc10fd8f1265 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Tue, 2 Sep 2014 12:00:03 +0200
Subject: [PATCH] CI: Do not try to find memory leaks with valgrind

We use talloc and valgrind needn't find memory leaks.
For this purpose, we have functions in file src/tests/leak_check.c
---
 contrib/ci/run | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/contrib/ci/run b/contrib/ci/run
index b8a296aea5b58e88382677eb1b4cff1edf420b8f..901a162b6698daf8b3d340362512f654504bfbfc 100755
--- a/contrib/ci/run
+++ b/contrib/ci/run
@@ -194,8 +194,6 @@ function build_debug()
     # Not building "tests" due to https://fedorahosted.org/sssd/ticket/2350
     stage make-tests        make-check-wrap -j $CPU_NUM check -- true
 
-    # Ignored until issues found by Valgrind are fixed
-    status=0
     CK_FORK=no \
         stage make-check-valgrind \
                 make-check-wrap -j $CPU_NUM check -- \
@@ -203,9 +201,8 @@ function build_debug()
                                     valgrind-condense 99 '!(*.py)' -- \
                                     --vgdb=no \
                                     --trace-children=yes \
-                                    --trace-children-skip='*/bin/*,*/sbin/*' \
-                                    --leak-check=full ||
-            status=$?
+                                    --trace-children-skip='*/bin/*,*/sbin/*'
+
     mv "$test_dir" ci-test-dir
 
     if "$MODERATE"; then
-- 
2.1.0



More information about the sssd-devel mailing list