[SSSD] [PATCH] LDAP: Set umask before calling mkstemp

Jakub Hrozek jhrozek at redhat.com
Tue Sep 2 08:53:40 UTC 2014


On Tue, Sep 02, 2014 at 09:13:05AM +0200, Sumit Bose wrote:
> On Mon, Sep 01, 2014 at 04:31:30PM +0200, Jakub Hrozek wrote:
> > Hi,
> > 
> > attached is a simple patch that fixes a Coverity warning.
> 
> This is the pattern we use elsewhere as well and the patch applies well,
> ACK.

Pushed to master:
    bd981608d8d174cd7309a992f393c43c1334eddd

> 
> bye,
> Sumit
> 
> P.S. Maybe it is a good time to open a ticket to check the umask() usage
> in the SSSD code, with a simple grep I can find the following variants:
> umask(0000)
> umask(0022)
> umask(0077)
> umask(0111)
> umask(0133)
> umask(0177)
> umask(022)
> umask(077)

I agree:
    https://fedorahosted.org/sssd/ticket/2424



More information about the sssd-devel mailing list