[SSSD] [PATCHES] Implement MIT Kerberos localauth plugin

Jakub Hrozek jhrozek at redhat.com
Mon Sep 1 15:31:32 UTC 2014


I'm sorry about the delay in review. I had to rebuild my test
infrastructure...

On Thu, Aug 21, 2014 at 06:36:13PM +0200, Sumit Bose wrote:
> > > --- a/contrib/sssd.spec.in
> > > +++ b/contrib/sssd.spec.in
> > > @@ -48,6 +48,10 @@
> > >      %global with_cifs_utils_plugin_option --disable-cifs-idmap-plugin
> > >  %endif
> > >  
> > > +%if (0%{?fedora} >= 21)
> > 
> > Do you think it's time to add a rule for RHEL-7.1 already? I'm just concerned
> > that we'll forget later. Alternatively we can just file a ticket.
> 
> Checking minor versions is a bit tricky, I hope you agree with my
> solution.

I did test by manually editing /etc/redhat-release and it seemed to
work fine.  Thanks!

[...]

> > Why do you also check min_ver here? All the plugins currently in tree
> > only check maj_ver as far as I can see. Or rather, what is the semantics
> > of the min_ver number?
> 
> If I understood the doc correctly the minor version can be used to
> enable/disable elements in the vtable.

Ah, I see. Thanks for the explanation.

> 
> > 
> > > +
> > > +    krb5_localauth_vtable vt = (krb5_localauth_vtable)vtable;
> > > +
> > > +    vt->init = NULL;
> > > +    vt->fini = NULL;
> > > +    vt->name = "sssd";
> > > +    vt->an2ln = sss_an2ln;
> > > +    vt->userok = sss_userok;
> > > +    vt->free_string = sss_freestr;
> > > +
> > > +    return 0;
> > >  }
> > >  
> > > -- 
> > > 1.8.3.1
> 
> New version attached.
> 
> bye,
> Sumit

This version looks good to me.

ACK.



More information about the sssd-devel mailing list