[SSSD] [PATCH] MONITOR: Fix warning may be used uninitialized

Michal Židek mzidek at redhat.com
Thu Oct 23 17:02:58 UTC 2014


On 10/23/2014 06:38 PM, Jakub Hrozek wrote:
> On Thu, Oct 23, 2014 at 06:35:07PM +0200, Jakub Hrozek wrote:
>> On Thu, Oct 23, 2014 at 02:14:03PM +0200, Michal Židek wrote:
>>> On 10/23/2014 11:36 AM, Lukas Slebodnik wrote:
>>>> ehlo,
>>>>
>>>> src/monitor/monitor.c: In function ‘main’:
>>>> src/monitor/monitor.c:2953:24: error: ‘monitor’ may be used uninitialized
>>>>                                 in this function [-Werror=maybe-uninitialized]
>>>>       monitor->is_daemon = !opt_interactive;
>>>>                          ^
>>>> cc1: all warnings being treated as errors
>>>>
>>>> This warning is caused be change 579e5d4b7a3ca161ea7518b2996905fa22c15995
>>>> "MONITOR: Allow confdb to be accessed by nonroot user"
>>>>
>>>> Patch is attached.
>>>>
>>>> LS
>>>>
>>
>> Not sure I understand, under what circumstances can errno be 0 while
>> chown returns 0?
>
> Err, while chown returns -1

That is why I said, I think it is false positive, but the warning
appears when compiling with -O2. So maybe some strange gcc optimization
can cause trouble here under some circumstances. I think it is better
to accept Lukas's patch (it at least removes the warning).

Michal




More information about the sssd-devel mailing list