[SSSD] [PATCH] MONITOR: Fix warning may be used uninitialized

Lukas Slebodnik lslebodn at redhat.com
Thu Oct 23 09:36:46 UTC 2014


ehlo,

src/monitor/monitor.c: In function ‘main’:
src/monitor/monitor.c:2953:24: error: ‘monitor’ may be used uninitialized
                               in this function [-Werror=maybe-uninitialized]
     monitor->is_daemon = !opt_interactive;
                        ^
cc1: all warnings being treated as errors

This warning is caused be change 579e5d4b7a3ca161ea7518b2996905fa22c15995
"MONITOR: Allow confdb to be accessed by nonroot user"

Patch is attached.

LS
-------------- next part --------------
>From 8c7572ac26018c840ba3d5ff704ffc8f555974cc Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Thu, 23 Oct 2014 10:55:08 +0200
Subject: [PATCH 3/3] MONITOR: Fix warning may be used uninitialized
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This warning is caused be change 579e5d4b7a3ca161ea7518b2996905fa22c15995
"MONITOR: Allow confdb to be accessed by nonroot user"

src/monitor/monitor.c: In function ‘main’:
src/monitor/monitor.c:2953:24: error: ‘monitor’ may be used uninitialized
                               in this function [-Werror=maybe-uninitialized]
     monitor->is_daemon = !opt_interactive;
                        ^
cc1: all warnings being treated as errors
---
 src/monitor/monitor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index 0dea327213a1ad04b6f69c0ffb0fb87254420796..b9810e272824270f3375f4785c219601f51e1289 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -1727,6 +1727,7 @@ static errno_t load_configuration(TALLOC_CTX *mem_ctx,
         DEBUG(SSSDBG_FATAL_FAILURE,
               "chown failed for [%s]: [%d][%s].\n",
               cdb_file, ret, sss_strerror(ret));
+        ret = (ret == 0) ? EINVAL: ret;
         goto done;
     }
 
-- 
2.1.0



More information about the sssd-devel mailing list