[SSSD] [PATCHES] GPO: fail if there is problem with storing gpo into sysdb

Jakub Hrozek jhrozek at redhat.com
Mon Oct 13 14:11:48 UTC 2014


On Mon, Oct 13, 2014 at 09:58:56AM +0200, Lukas Slebodnik wrote:
> On (12/10/14 17:21), Jakub Hrozek wrote:
> >On Sat, Oct 11, 2014 at 11:49:54PM +0200, Lukas Slebodnik wrote:
> >> ehlo,
> >> 
> >> some variable could be used unitialized.
> >> 
> >> Simple patches are attached.
> >> 
> >> LS
> >
> >> From f2a7faefba6e6191f324c4c33609ccb7570835e5 Mon Sep 17 00:00:00 2001
> >> From: Lukas Slebodnik <lslebodn at redhat.com>
> >> Date: Sat, 11 Oct 2014 12:55:05 +0200
> >> Subject: [PATCH 7/9] GPO: fail if there is problem with storing gpo into sysdb
> >> 
> >> ---
> >>  src/providers/ad/ad_gpo.c | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >> 
> >> diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
> >> index 9f52aedf8d10d6a870846f311b5347896fba31bd..6fdcbe3fe65b31d56123ddea95a5e46282cfb599 100644
> >> --- a/src/providers/ad/ad_gpo.c
> >> +++ b/src/providers/ad/ad_gpo.c
> >> @@ -1147,6 +1147,11 @@ ad_gpo_store_policy_settings(struct sss_domain_info *domain,
> >>                  ret = sysdb_gpo_store_gpo_result_setting(domain,
> >>                                                           allow_key,
> >>                                                           allow_value);
> >> +                DEBUG(SSSDBG_CRIT_FAILURE,
> >> +                      "sysdb_gpo_store_gpo_result_setting failed for key:'%s' "
> >> +                      "value:'%s' [%d][%s]\n", allow_key, allow_value,
> >> +                      ret, sss_strerror(ret));
> >> +                goto done;
> >
> >I think the debug and goto should be wrapped in an if statement here.
> >
> >>              }
> >>          }
> >>  
> >> @@ -1166,6 +1171,11 @@ ad_gpo_store_policy_settings(struct sss_domain_info *domain,
> >>                  ret = sysdb_gpo_store_gpo_result_setting(domain,
> >>                                                           deny_key,
> >>                                                           deny_value);
> >> +                DEBUG(SSSDBG_CRIT_FAILURE,
> >> +                      "sysdb_gpo_store_gpo_result_setting failed for key:'%s' "
> >> +                      "value:'%s' [%d][%s]\n", deny_key, deny_value,
> >> +                      ret, sss_strerror(ret));
> >> +                goto done;
> >
> >Same here
> >
> Copy paste problem.
> Fixed version is attached.
> 
> LS

ACK



More information about the sssd-devel mailing list