[SSSD] [PATCH] SDAP: test return value of sysdb_search_services

Lukas Slebodnik lslebodn at redhat.com
Sat Oct 11 21:46:13 UTC 2014


ehlo,

return value from function sysdb_search_services was not tested.

simple patch is attached.

LS
-------------- next part --------------
>From c6e756909cb1d8b002122b6bb0f4274b3d831ff6 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lslebodn at redhat.com>
Date: Fri, 10 Oct 2014 19:39:02 +0200
Subject: [PATCH 4/9] SDAP: test return value of sysdb_search_services

---
 src/providers/ldap/sdap_reinit.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/providers/ldap/sdap_reinit.c b/src/providers/ldap/sdap_reinit.c
index 265453fdff67b5f2c007282f30e3ad3564e7e37b..d5c896774fe684154a46242169ca596d38a42bfc 100644
--- a/src/providers/ldap/sdap_reinit.c
+++ b/src/providers/ldap/sdap_reinit.c
@@ -297,6 +297,12 @@ static errno_t sdap_reinit_delete_records(struct sss_domain_info *domain)
     /* purge untouched services */
     ret = sysdb_search_services(tmp_ctx, domain, "(!("SYSDB_USN"=*))",
                                 attrs, &msgs_num, &msgs);
+    if (ret != EOK) {
+        DEBUG(SSSDBG_OP_FAILURE,
+              "Cannot search services [%d]: %s\n", ret, strerror(ret));
+        goto done;
+    }
+
     sdap_delete_msgs_dn(sysdb, msgs, msgs_num);
     talloc_zfree(msgs);
     msgs_num = 0;
-- 
2.1.0



More information about the sssd-devel mailing list