[SSSD] [PATCH] SYSDB: move sysdb_get_real_name() from sysdb.c to sysdb_search.c

Jakub Hrozek jhrozek at redhat.com
Mon Oct 6 13:05:38 UTC 2014


On Mon, Oct 06, 2014 at 09:27:26AM +0200, Lukas Slebodnik wrote:
> On (03/10/14 18:09), Jakub Hrozek wrote:
> >Another cleanup patch I had in my branch.
> 
> >From 60e29ae51262ef5e25c4c59b8a0f8a80be69ae61 Mon Sep 17 00:00:00 2001
> >From: Jakub Hrozek <jhrozek at redhat.com>
> >Date: Sun, 21 Sep 2014 16:55:21 +0200
> >Subject: [PATCH] SYSDB: move sysdb_get_real_name() from sysdb.c to
> > sysdb_search.c
> >
> >The sysdb.c should be reserved for utility and setup functions. Search
> >functions belong to sysdb_search.c Keeping functions in specialized
> >modules helps to maintain nice dependencies and in overall makes unit
> >testing easier.
> >
> >Moreover, the function was not unit tested, which needed fixing.
> >---
> Make sense and does not break anything :-)
> 
> ACK
> 
> LS

* master: d7d3ee1b8ab7a05129c83da8a185351d7c751c1c



More information about the sssd-devel mailing list