[SSSD] [PATCH] MONITOR: Make internal functions static

Jakub Hrozek jhrozek at redhat.com
Fri Oct 3 14:47:31 UTC 2014


Please see the attached trivial patch.
-------------- next part --------------
>From c7f02a268e0b631e858d46ccc93e4e4dee246fcc Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Tue, 5 Aug 2014 15:26:48 +0200
Subject: [PATCH] MONITOR: Make internal functions static

Several functions in the monitor.c file were not marked as static even
though they were only used inside monitor.c
---
 src/monitor/monitor.c | 26 +++++++++++++-------------
 src/monitor/monitor.h |  3 ---
 2 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index 39f4e6437e1a60c830a30b4596a385b3c54ea167..46b630c2540065c3a0eeb3575842cf9f56c706e1 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -912,7 +912,7 @@ static char *check_services(char **services)
     return NULL;
 }
 
-int get_monitor_config(struct mt_ctx *ctx)
+static int get_monitor_config(struct mt_ctx *ctx)
 {
     int ret;
     int timeout_seconds;
@@ -1665,11 +1665,11 @@ done:
     return ret;
 }
 
-errno_t monitor_config_file_fallback(TALLOC_CTX *mem_ctx,
-                                     struct mt_ctx *ctx,
-                                     const char *file,
-                                     monitor_reconf_fn fn,
-                                     bool ignore_missing);
+static errno_t monitor_config_file_fallback(TALLOC_CTX *mem_ctx,
+                                            struct mt_ctx *ctx,
+                                            const char *file,
+                                            monitor_reconf_fn fn,
+                                            bool ignore_missing);
 
 #ifdef HAVE_INOTIFY
 static void process_config_file(struct tevent_context *ev,
@@ -2079,11 +2079,11 @@ static int monitor_config_file(TALLOC_CTX *mem_ctx,
     return ret;
 }
 
-errno_t monitor_config_file_fallback(TALLOC_CTX *mem_ctx,
-                                     struct mt_ctx *ctx,
-                                     const char *file,
-                                     monitor_reconf_fn fn,
-                                     bool ignore_missing)
+static errno_t monitor_config_file_fallback(TALLOC_CTX *mem_ctx,
+                                            struct mt_ctx *ctx,
+                                            const char *file,
+                                            monitor_reconf_fn fn,
+                                            bool ignore_missing)
 {
     struct config_file_callback *cb = NULL;
     struct stat file_stat;
@@ -2138,8 +2138,8 @@ errno_t monitor_config_file_fallback(TALLOC_CTX *mem_ctx,
     return EOK;
 }
 
-int monitor_process_init(struct mt_ctx *ctx,
-                         const char *config_file)
+static int monitor_process_init(struct mt_ctx *ctx,
+                                const char *config_file)
 {
     TALLOC_CTX *tmp_ctx;
     struct tevent_signal *tes;
diff --git a/src/monitor/monitor.h b/src/monitor/monitor.h
index ab23e005cc201e64a9c4f087058b0a29c44ebec7..b5a300bf3c9b281b5e9ffa76872ff30668865117 100644
--- a/src/monitor/monitor.h
+++ b/src/monitor/monitor.h
@@ -37,9 +37,6 @@ typedef int (*monitor_reconf_fn) (struct config_file_ctx *file_ctx,
 
 struct mt_ctx;
 
-int monitor_process_init(struct mt_ctx *ctx,
-                         const char *config_file);
-
 /* from monitor_netlink.c */
 struct netlink_ctx;
 
-- 
1.9.3



More information about the sssd-devel mailing list