[SSSD] [PATCH] nss: Preserve case of group members

Jakub Hrozek jhrozek at redhat.com
Wed Oct 1 15:21:44 UTC 2014


On Wed, Oct 01, 2014 at 05:11:56PM +0200, Michal Židek wrote:
> On 10/01/2014 04:57 PM, Jakub Hrozek wrote:
> >On Wed, Oct 01, 2014 at 04:09:55PM +0200, Michal Židek wrote:
> >>Hi,
> >>
> >>see attached simple patch that fixes ticket:
> >>https://fedorahosted.org/sssd/ticket/2453
> >>
> >>Michal
> >
> >Do you remember why do we have separate preserve and sensitive? Would it
> >be better to merge the two?
> >
> 
> It would require more refactoring to merge the two. We have a lot
> of places where we rely on the domain->case_sensitive to be bool
> and it may introduce a lot of bugs if we were not careful enough
> when doing the merge.
> 
> The domain->case_preserve is only used in get*nam calls and only
> when dealing with values that will be returned to caller. It
> is much less invasive to have separate variable for these
> few cases and leave the rest of SSSD untouched.
> 
> Michal

OK, thanks.



More information about the sssd-devel mailing list